[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Cleaning up koGlobal.cc
From:       Philipp =?ISO-8859-1?Q?M=FCller?= <philipp.mueller () gmx ! de>
Date:       2003-03-06 9:02:34
[Download RAW message or body]

Hello Nicolas,

sorry for answering a bit late.

I checked your changes and agree, this is the thing to do now (which is the
way, what we can do for KO 1.3).

But in general, I don't like the basic design.

Our current design defines the available sizes on our own. It doesn't use
the defined ones in kprinter, which itself depends on the ones in QT.

So, in case QT adds another definition, kprinter has to wait for the QT
release and then can add the new one to it's own list. After about 1 year, we
will be able somehow to add it to our list as well (as we should be backwards
compatible to the KDE version as well. Or we add them now into our own list,
but maybe we have rounding differences to the one in QT/KPrinter, which we
either will have all the time (eek) or need to program around somehow.

That means, we would always need to wait up to 2 years, until we can provide
the new size of QT to the users. I don't like this very much, as it gives
the user the impression KO can do less than KDE can do (they find this page
size in all other non KO apps).

Of course, atm there is no
   QList kprinter->availablePageSizes()
and
  QSize (or KoSize) kprinter->pageSizeInMM( KPrinter::format )
available yet.

So for KO 1.3 we are stuck with the current definition.

But for KO 1.4, IMHO we should ask Michael for such methods and can later on
replace our defintion with the ones from KPrinter.

I don't see a real point, why we have our own definiton.

What doyou think?

Philipp

-- 
+++ GMX - Mail, Messaging & more  http://www.gmx.net +++
Bitte lächeln! Fotogalerie online mit GMX ohne eigene Homepage!

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]