[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KoStore diff for direct file extracting/adding
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-02-02 12:00:17
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 01 February 2003 22:32, Percy Leonhardt wrote:
> As I don't know the internals of Qt maybe David can comment on this, if 
> copying for example 300 MB by reading and writing it in chunks of 8kB is 
> faster or slower than letting Qt do it and hope that it will optimize this 
> task somehow.

It should be about the same speed. But the memory usage, if you use readAll()
on a huge file, would be awful (and when it starts swapping, then you get
a big slow down, obviously). Copying by chunks is definitely preferred here
 - don't trust Qt too much, it only does what you ask it to do :)

Lucijan: please add "diff -up" to you ~/.cvsrc file. Your diff isn't in unified form.
The patch looks good. I'm only wondering about the size!=-1 check in extractFile.
It's not a big deal if we don't know the size before hand (and IIRC KoTarStore
doesn't know the size). Just extract the file and skip the total==dsize check,
if the size isn't known.

- -- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+PQhS72KcVAmwbhARAmYVAKCaDXmukXDfIs1bxDic7ly2b20E5wCfXxgd
SzrrNxzkej+EfrM9LrC/kH8=
=g1ua
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]