[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KoUnit..
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-01-01 11:56:39
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 26 December 2002 00:59, Peter Simonsson wrote:
> On Wednesday 25 December 2002 22.42, David Faure wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Monday 23 December 2002 22:13, Peter Simonsson wrote:
> > > Hi!
> > > I'm wondering if the attached patch could be applied to KoUnit?
> > > The patch add three new units, namely pica, didot and cicero. These units
> > > are used by kivio which right now uses it's own lib for units and other
> > > things already present in koffice. This I want to change as it is a major
> > > source for bugs.
> >
> > Looks good, assuming those units are indeed useful to anyone.......
> >
> I have applied them so lets hope someone does use them. :)

The DD unit seems to have wrong conversion values.
POINT_TO_DD( DD_TO_POINT( 1 ) ) isn't equal to 1.
Please check this.
It would also be a good idea to add the definition of the units,
in the comments above those macros, to help debugging such problems :)

- -- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+Etd472KcVAmwbhARAjStAKCgq2on5jx9X6jNuJMY6VMFE49s1wCfUbfU
MoV8Y9OPWkJvSOjg+mQUA6E=
=sWT8
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]