[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: #if KDE_VERSION >= 305 in koffice to use 3.1 interfaces.... *BOOM*.
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-11-12 23:03:53
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 12 November 2002 15:01, AlanE wrote:
> Because 305 got used as a synonym for "almost to 3.1", there's code in
> koffice-1.2 that uses "if KDE_VERSION >= 305" to check whether to use
> the 3.1 interfaces. 

Yup, should have been > 305. "Tap" told me on IRC today.
(Note: since KDE-3.1-alpha1 had KDE_VERSION=306, Dirk assured me
that even if a 3.0.6 is ever released, it won't have KDE_VERSION changed...)

> Since we have a real 3.0.5, then koffice calls the 3.1 interfaces which
> don't exist yet. For a good example, see
> koffice-1.2/lib/kofficecore/koMainWindow.cc. KOffice is gonna need to
> have all those #if checks changed or else it's broken with 3.0.5.

I just fixed this today in the KOFFICE_1_2_BRANCH, using >305 and <=305.

We'll release koffice-1.2.1 soon, with that fix and of course many others.
I wanted to wait until KDE-3.1 is out - not that we'll require it, but simply
to avoid doing all the releases at the same time... But maybe it would be
wiser to release koffice-1.2.1 between KDE-3.0.5 and KDE-3.1, in particular
in the light of the above issue?

To the list: is there any fix that should be in the branch before we can 
release KOffice-1.2.1 ?

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE90Yja72KcVAmwbhARAtQ6AKCgMYaAVHKUO2ywYTyAxhcshOF7cwCfcXqS
Q2+K3yB0Q9JhVEKhXh39YL4=
=7DX2
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]