[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [kspread] integrating KSpreadValue (and some ramblings)
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-10-31 10:02:58
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 31 October 2002 08:53, Ariya Hidayat wrote:
> > If you think it makes sence, yes we can put it out of KSpreadCell, but I
> > don't know what we will really gain beside of better abstraction.
> > Public should be paintCell only. Borders and Background are called by
> > paintCell only.
> > Or do you mean the other ones like makeLayout or textSize? These are not
> > really painting related, as they are used mostly to define position, size
> > and lenght of displayed text in zoom independet values (yes, currently not
> > completely independent, but should be at the end). These methods maybe part
> > of the layout class as well or we should keep them in KspreadCell IMHO.
> > So it would be the (I think 6) painting methods in KSpreadCell, which is
> > not too much code to be needed to seperate.
> 
> My idea is that because of KSpreadCell's size, it should be arranged so that 
> it will be at least "humanly manageable". One way to do this is to split many 
> properties (and functionalities) into separate classes. That's why I propose 
> painting-related stuff to be put in another class. 
> Perhaps David or others could explain how this is done in KWord/KPresenter ?

Painting is done in the relevant classes themselves, but kword/kpresenter/kotext
have a more modular design than KSpread, I feel. KSpreadCell takes care of
all the text painting, when in fact it should use KoTextParag to do it ;) Once the
switch to kotext is done, you should see less painting code in KSpreadCell already.

For properties.... all the border/color/font/etc. stuff is already out of KSpreadCell,
in KSpreadLayout, no?

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9wP/S72KcVAmwbhARAnUFAJwMuijbTCz76Ze3zyHQAX8g+5vP8wCcD1UT
Z+Zde+g/zx++oaEoCnSQ/uQ=
=Qjmx
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]