[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch to fix bug #44928
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-08-29 11:53:50
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 29 August 2002 09:52, Ariya Hidayat wrote:
> 
> Here is a (bit nasty) workaround to fix KSpread bug #44928 (printing doesn't 
> fill the page).
> 
> Problem: open Page Layout Dialog, change bottom border to 0, then click OK 
> RIGHT AFTERWARDS. Then if you open the dialog again, bottom border is not 0. 
> It's still the previous value sitting in there.
> 
> Reason: in kspread_dlg_paperlayout.cc, borders are taken from 
> KoPageLayoutDia::layout(). when bottom border is changed and right-after OK 
> button is clicked, KoPageLayoutDia::bottomChanged() is not emitted correctly 
> (at least before calling KoPageLayoutDia::layout()). Hence, the layout that 
> is passed is the previous value. (Perhaps problem in KDoubleNumInput ?)

Yes, I think this is a bug in KDoubleNumInput. IIRC it didn't use to behave like
that. I've seen this bug too, in KWord's dialog boxes.

Cc'ing the KDoubleNumInput authors.
(If the above is confusing, here's another description of the problem:
KDoubleNumInput seems to use a timer for sending its signals (right? why?) so 
when the user updates the value and closes the dialog right away, no signal 
has been emitted, so the new value is lost).

If this is indeed the case, and the reason is like "to avoid sending signals on
every arrow click", then 1) this means the signals are not reliable anymore,
which is bad, 2) typing a value by hand shouldn't have this delay anyway.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9bgtO72KcVAmwbhARAnkFAJ986C5X46JomZKpq6yDIqAIbSH+MwCbBHMr
fXBdPsl3VFQ6iUm4fUohEHA=
=6pvF
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]