From koffice-devel Fri Aug 23 23:36:25 2002 From: Ariya Hidayat Date: Fri, 23 Aug 2002 23:36:25 +0000 To: koffice-devel Subject: patch to fix bug #46352 (fwd) X-MARC-Message: https://marc.info/?l=koffice-devel&m=103037629321390 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--0-215996490-1030145746=:23195" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-215996490-1030145746=:23195 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: The following is a patch to fix bug #46352 (kword crashes on opening a *.doc file) The problem: drawingId for PICF is 32314372 while the size of data stream is only 348705. Abiword also crashed with the document, and I've got error in wvWare, i.e "wvError: (picf.c:154) X is f4b0". I'm not familiar with wvWare but nevertheless will take a look. The workaround: sentinel check to see whether drawingId is in the proper range. To Werner or Shaheed: is it OK if I add such sentinel check everywhere ? After investigating many bug reports regarding MS Word import, most of the problems are invalid range, and thus triggers nasty memory reference, like this one. (Do MS Word files always have these inconsistencies anyway ?) --0-215996490-1030145746=:23195 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="picf.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="picf.patch" SW5kZXg6IG1zd29yZC5jYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT IGZpbGU6IC9ob21lL2tkZS9rb2ZmaWNlL2ZpbHRlcnMvb2xlZmlsdGVycy93 aW53b3JkOTcvbXN3b3JkLmNjLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS44 MQ0KZGlmZiAtdSAtMyAtcCAtcjEuODEgbXN3b3JkLmNjDQotLS0gbXN3b3Jk LmNjCTIwMDIvMDcvMDUgMDk6MDE6MjYJMS44MQ0KKysrIG1zd29yZC5jYwky MDAyLzA4LzIzIDIzOjMzOjE1DQpAQCAtODQ3LDYgKzg0Nyw5IEBAIGJvb2wg TXNXb3JkOjpnZXRQaWN0dXJlKA0KICAgICB1bnNpZ25lZCBieXRlczsNCiAg ICAgUVN0cmluZyB0aWZmRmlsZW5hbWU7DQogDQorICAgIC8vIHNlbnRpbmVs IGNoZWNrDQorICAgIGlmKCBmYyA+IG1fZGF0YVN0cmVhbUxlbmd0aCApIHJl dHVybiBmYWxzZTsNCisNCiAgICAgLy8gR2V0IHRoZSBQSUNGLg0KIA0KICAg ICBwaWN0dXJlVHlwZSA9ICIiOw0KQEAgLTk1Nyw2ICs5NjAsNyBAQCBNc1dv cmQ6Ok1zV29yZCgNCiAgICAgICAgIG1fdGFibGVTdHJlYW0gPSB0YWJsZTFT dHJlYW0uZGF0YTsNCiAgICAgfQ0KICAgICBtX2RhdGFTdHJlYW0gPSBkYXRh U3RyZWFtLmRhdGE7DQorICAgIG1fZGF0YVN0cmVhbUxlbmd0aCA9IGRhdGFT dHJlYW0ubGVuZ3RoOw0KICAgICBpZiAoIW1fdGFibGVTdHJlYW0pDQogICAg IHsNCiAgICAgICAgIC8vIE9sZGVyIHZlcnNpb25zIG9mIFdvcmQgaGFkIG5v IHNlcGFyYXRlIHRhYmxlIHN0cmVhbS4NCkBAIC05NzAsNiArOTc0LDcgQEAg TXNXb3JkOjpNc1dvcmQoDQogDQogICAgICAgICBrZERlYnVnKHNfYXJlYSkg PDwgIk1zV29yZDo6TXNXb3JkOiBubyBkYXRhIHN0cmVhbSIgPDwgZW5kbDsN CiAgICAgICAgIG1fZGF0YVN0cmVhbSA9IG1fbWFpblN0cmVhbTsNCisgICAg ICAgIG1fZGF0YVN0cmVhbUxlbmd0aCA9IG1haW5TdHJlYW0ubGVuZ3RoOw0K ICAgICB9DQogDQogICAgIC8vIFdlIG11c3QgY2FsbCByZWFkU3R5bGVzKCkg Zmlyc3QsIGFzIHdlIHVzZSB0aGUgU1RTSEkgc2l6ZSB0byBkZXRlY3QNCklu ZGV4OiBtc3dvcmQuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9ob21lL2tkZS9rb2ZmaWNlL2ZpbHRlcnMvb2xlZmlsdGVycy93aW53 b3JkOTcvbXN3b3JkLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQyDQpk aWZmIC11IC0zIC1wIC1yMS40MiBtc3dvcmQuaA0KLS0tIG1zd29yZC5oCTIw MDIvMDUvMTMgMTc6NTI6MjAJMS40Mg0KKysrIG1zd29yZC5oCTIwMDIvMDgv MjMgMjM6MzM6MTYNCkBAIC0zOTAsNiArMzkwLDcgQEAgcHJpdmF0ZToNCiAg ICAgY29uc3QgVTggKm1fbWFpblN0cmVhbTsNCiAgICAgY29uc3QgVTggKm1f dGFibGVTdHJlYW07DQogICAgIGNvbnN0IFU4ICptX2RhdGFTdHJlYW07DQor ICAgIFUzMiBtX2RhdGFTdHJlYW1MZW5ndGg7DQogICAgIEZJQiBtX2ZpYjsN CiANCiAgICAgbXlGaWxlIG1haW5TdHJlYW07DQo= --0-215996490-1030145746=:23195-- _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/koffice-devel