From koffice-devel Mon Aug 19 16:31:19 2002 From: Ariya Hidayat Date: Mon, 19 Aug 2002 16:31:19 +0000 To: koffice-devel Subject: patch to fix bug #18083 X-MARC-Message: https://marc.info/?l=koffice-devel&m=102977479904592 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--0-903748308-1029774679=:15771" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-903748308-1029774679=:15771 Content-Type: TEXT/PLAIN; charset=US-ASCII The following patch fix bug #18083 (kspread rounding error). Problem: in most system (including mine), printf("%.2f",x) results in "63.15" if x is 63.145 but "64.14" if x is 64.145. For the latter, it should be "64.15" (I checked with MS Excel). So it's not KLocale's or QString's fault. I don't know exactly what might cause this (broken libc?) Solution: round the number before passing it to KLocale::formatNumber(). Hopefully it doesn't introduce noticable penalty. OK to commit ? (John: sorry if this duplicates your work/investigation). --0-903748308-1029774679=:15771 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="rounding.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="rounding.patch" SW5kZXg6IGtzcHJlYWRfY2VsbC5jYw0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KUkNTIGZpbGU6IC9ob21lL2tkZS9rb2ZmaWNlL2tzcHJlYWQva3NwcmVh ZF9jZWxsLmNjLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS40MzUNCmRpZmYg LXUgLTMgLXAgLXIxLjQzNSBrc3ByZWFkX2NlbGwuY2MNCi0tLSBrc3ByZWFk X2NlbGwuY2MJMjAwMi8wOC8xOCAxNToyMDoyOAkxLjQzNQ0KKysrIGtzcHJl YWRfY2VsbC5jYwkyMDAyLzA4LzE5IDE2OjE0OjQxDQpAQCAtMTE4Niw2ICsx MTg2LDEzIEBAIFFTdHJpbmcgS1NwcmVhZENlbGw6OmNyZWF0ZUZvcm1hdCgg ZG91YmwNCiAgICAgUVN0cmluZyBsb2NhbGl6ZWROdW1iZXI9IGxvY2FsZSgp LT5mb3JtYXROdW1iZXIoIHZhbHVlLCBwICk7DQogICAgIGludCBwb3MgPSAw Ow0KIA0KKyAgICAvLyByb3VuZCB0aGUgbnVtYmVyLCBiYXNlZCBvbiBkZXNp cmVkIHByZWNpc2lvbg0KKyAgICBkb3VibGUgbVtdID0geyAxLCAxMCwgMTAw LCAxZTMsIDFlNCwgMWU1LCAxZTYsIDFlNywgMWU4LCAxZTksIDFlMTAgfTsN CisgICAgZG91YmxlIG1tID0gKHAgPiAxMCkgPyBwb3coMTAuMCxwKSA6IG1b cF07DQorICAgIGJvb2wgbmVnID0gdmFsdWUgPCAwOw0KKyAgICB2YWx1ZSA9 IGZsb29yKCBmYWJzKHZhbHVlKSptbSArIDAuNSApIC8gbW07DQorICAgIGlm KCBuZWcgKSB2YWx1ZSA9IC12YWx1ZTsNCisNCiAgICAgc3dpdGNoKCBmb3Jt YXRUeXBlKCkgKQ0KICAgICB7DQogICAgIGNhc2UgTnVtYmVyOg0K --0-903748308-1029774679=:15771-- _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/koffice-devel