[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch for KSpread bug 45944
From:       John Dailey <dailey () vt ! edu>
Date:       2002-08-10 15:28:29
[Download RAW message or body]

I don't see any problems with this.

-John

On Wednesday 07 August 2002 05:16 pm, Norbert Andres wrote:
> Sorry, hit the wrong key accidently.
>
> Here is the patch...
>
> Shall I commit?
>
>
> Another thing I would like to change is:
>
> Index: kspread_layout.cc
> ===================================================================
> RCS file: /home/kde/koffice/kspread/kspread_layout.cc,v
> retrieving revision 1.92
> diff -u -r1.92 kspread_layout.cc
> --- kspread_layout.cc   2002/07/27 16:19:26     1.92
> +++ kspread_layout.cc   2002/08/07 21:07:55
> @@ -622,7 +622,7 @@
>      if ( !font.isNull() )
>          setTextFont( toFont(font) );
>
> -    if(pm!=NoBorder)
> +    if ((pm != NoBorder) && (pm != Text) && (pm != Comment))
>      {
>          QDomElement left = f.namedItem( "left-border" ).toElement();
>          if ( !left.isNull() )
>
> ... because we don't need to change the border if we only want to paste
> (Edit->Special paste) the comments or only the text.
>
> Regards
> Norbert
>
> On Wednesday 07 August 2002 23:11, Norbert Andres wrote:
> > Bug #45944 (Normal): Paste special->text overwrite borders
> >
> > I've looked into the bug 45944 and I would like to get an approval (since
> > we are in deep freeze) that the attached patch fixes this bug but doesn't
> > introduce new bugs.
> >
> > I tested it for quite a while not and it seems to work.
> >
> > kspread_cell.patch:
> >
> > the idea behind this patch is that I don't want to change a cell from the
> > cluster if I only copy data from this cell to a dummy cell (which is not
> > part of the cluster). I posted some details to bugs.kde.org for this bug.
> >
> > So before I delete a property of another cell I check if the current cell
> > is a dummy cell and if it is one, I don't allow changing other cells:
> >
> >
> >
> > **********************************
> >
> > create a new document
> > in the cell A1 type a number
> > select B1:B6 and pur "All borders"
> > select A1 and copy the cell
> > menu Edit -> Special paste
> > choose "Text" and ok
> >
> > =>borders disappear
> >
> > kspread is cool !
> > thanks
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@mail.kde.org
> > http://mail.kde.org/mailman/listinfo/koffice-devel

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]