[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] save embedded documents
From:       Dag Andersen <danders () get2net ! dk>
Date:       2002-07-26 17:59:25
[Download RAW message or body]

Hi, David,
I think we *must* be talking about different things here :)
Unfortunatly I'm off on holiday now (Norwegian mountains) and haven't 
the time to finish this thing off now, OTOH, it is as you say, not 
_very_ important right now so we can get back to it after the 
release. I'm sure you have enough on your hands right now anyway.
Hope the release goes well !

On Thursday 25 July 2002 13:01, David Faure wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thursday 18 July 2002 11:34, Dag Andersen wrote:
> > > Embedded external docs are not really supported at the moment
> > > (no GUI for it, only part of the handling is there)
> >
> > Yes, well, it is possible to embedd docs in kword and as the
> > saving is a bit eratic I thought I'd close this hole before
> > release.
>
> You mean, when creating a KWord file by hand, that uses an external
> embedded doc? I know of no other way.
>
> > As I see it, there are 2 concerns:
> > 1) To detect that _any_ document has been modified (main or
> > embedded). For this childIsModified() is used.
> > 2) To query when saving modified external embedded documents. For
> > this I meant to use queryCloseExternalChildren(). And if _only_
> > an external doc is changed, no need to save main doc. And also,
> > it's nice (necessary?) to have individual control of external
> > docs. I think it's a bit rude just to overwrite docs wo even a
> > hint of what's going on.
>
> Ok.
>
> > New patch:
> > Does the above. Have moved queryCloseExternalChildren() to
> > KWdocument, so 2) only applies to kword.
>
> Hmm, why? Now that I understand what it's for, I preferred when it
> was in the libs. This is going to lead to code duplication,
> otherwise - all apps are going to do this the same way, aren't
> they?
>
> > It was the intention _not_ to change the current behaviour of the
> > save button, but with this solution external docs are now _only_
> > saved if changed. (I'm not sure if that's a pro or con, though.:)
> > If it's a problem I need some extra state or rethink the whole
> > thing.
>
> This is fine with me. External docs need a big thinking session
> anyway, I don't care much about them right now.
>
> I'd say: please commit the first patch ;)
> Thanks.
>
> - --
> David FAURE, david@mandrakesoft.com, faure@kde.org
> http://people.mandrakesoft.com/~david/
> Contributing to: http://www.konqueror.org/, http://www.koffice.org/
> Back from holidays - 1750 mails
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iD8DBQE9P9qG72KcVAmwbhARArRlAJ9xFfCMV5smg6RUZkYD/yBa9moWcgCdHEV0
> 8poqP10HEg7VzOBfD/LJg+Q=
> =ByWQ
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/koffice-devel

-- 
Mvh,
Dag Andersen
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]