[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] No mime attribute
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-06-25 7:00:19
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 24 June 2002 23:56, Thomas Zander wrote:
> On Mon, Jun 24, 2002 at 10:33:25PM +0200, Nicolas Goutte wrote:
> > The following patches are for kword, kpresenter and for the converting script.
> > 
> > The patches remove the "mime" attribute of the <DOC> element and adapt the 
> > code to support it.
> > 
> > The reason is that the mime type given there:
> > - is redundant to the "xmlns" attribute
> > - will change soon
Yes (but we are prepared for this change at least in that part of the code)

> > - is the mime type of the container and not of the XML file
Not really. You can open the standalone XML file with the app directly,
so there is a mapping between the two.

> This is not completely accurate; for starters the new packaging format defines
> that the XML stream should definitely define which application can load the 
> stream.
> 
> The discussion on the openoffice list also looked at the usage of the xmlns 
> and decided that it is not usefull for some time since all desktops use a mime-
> type approuch, therefor we decided that both will be supplied.

Hmm. I think this was about the "mimetype" file in the archive, which would
remain anyway, it's not the one Nicolas wants to remove.

> The 'will change soon' is true, but not a reason to remove it. Better to have
> an accurate old mime then no mime at all.

I'm with that though.

> The idea (also discussed at the openoffice lists) is that one document can be
> taken out of the container and still has meaning.  For this reason an embedded
> kspread file has the mime of kspread, even if it is in a kword container.
I agree.

> I'm don't think the mime should be removed, please don't commit.

All the rest of the patch looks great though.
Using 1.1 in createDomDocument is completely correct, we overlooked that up to now ;)
I'm all for this patch, just with one if() removed - always output the mimetype.
(and then testing for the mimetype or testing for the namespace doesn't matter
much... maybe keep the mimetype test, I don't think all the import filters have been
fixed to output the namespace!)

Don't forget to change the other apps the same way (the SaveAsKoffice1Dot1 -> "1.1" thing)

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is coming very shortly...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9GBUD72KcVAmwbhARAu2ZAJ9r0251EJZHLxqj6ghOBsd1AonOlQCghFMT
j3Qmk38htejCNFp2ARrdMBA=
=V9lo
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]