[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] kword table col insertion
From:       Thomas Zander <zander () planescape ! com>
Date:       2002-05-19 9:58:16
[Download RAW message or body]

On Wed, May 15, 2002 at 08:32:09AM +0200, Emmanuel Touzery wrote:
> argl...
> there was a isEnoughSpaceForNewCol() function is KWTableFrameSet that i 
> declared but did not define nor call. corrected patch attached.
> 
> ----------  Forwarded Message  ----------
> Subject: Re: [PATCH] kword table col insertion
> Date: Wed, 15 May 2002 08:26:27 +0200
> From: Emmanuel Touzery <emmanuel.touzery@wanadoo.fr>
> To: koffice-devel@kde.org
> 
> 
> Hello,
> 
> 	this patch should be ok this time, with all of your comments taken into
> account.

Ok, sorry it took a little longer then expected; been a bit busy here..
Plus I had to fix some table bug others introduced lately (not by you) :(

I changed one thing;  (in KWTableFrameSet::insertCol)
Q_ASSERT( width >=minFrameWidth );   is a bit harsh; as this can also be
called from dcop I don't want to assert the value; so I replaced it with
width=QMAX(width,minFrameWidth);

Commited your work; thanx!



> emmanuel
> 
> PS: FWIW, about the accolades styles, i checked and java.lang.String uses
> both styles in that same file :O) so i guess there is not really a default
> java style :O)
Hehe; I work with Java daily; and (IMOHO) the worst Java designs come from 
Sun, nobody ever claimed they follow their own rulebook, but everyone agrees 
that Suns rulebook is the standard (following the standard is a different 
matter).

-- 
Thomas Zander                                           zander@planescape.com
                                                 We are what we pretend to be

[Attachment #3 (application/pgp-signature)]
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]