[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KPlato
From:       Bo Thorsen <bo () sonofthor ! dk>
Date:       2002-03-19 13:14:49
[Download RAW message or body]

On Tuesday 19 March 2002 13:56, Thomas Zander wrote:
> On Tue, Mar 19, 2002 at 01:26:55PM +0100, Bo Thorsen wrote:

> > First is a general style issue: Why are you not using namespaces? Is this
> > feature not allowed in KDE or just in KOffice or has it just not been
> > done? I don't much like when enums are placed in global namespace or when
> > classes have prefixes like platos KPT (KPTProject, KPTDuration etc).
>
> The namespaces for enums have been used as much as I could; and all the
> global ones I have not found a way to put them inside a class.
> I am certainly not a perfect c++ coder; so if I missed something; please
> correct me. I am using Java too much outside of KDE..

I was thinking more about c++ namespaces, both for enums and classes. But it 
doesn't seem like namespaces are used much in KDE.

> The KPT prefixes seemed obvious to me, this is to not run into problems or
> create wierd names since normal ones are used somewhere else allready. 
> After all; one day we will use kofice document and view components which
> also have a KO prefix. Please keep the prefix.

Ok, it stays.

> > Specific code question: What is KPTDuration.zero used for? It seems like
> > a baseline in time, but since it's never set to anything but QDate(0,1,1)
> > and each instance still have one, is there some more subtle point I'm
> > missing, or should it actually be a static var?
>
> It's used as a base time; yes. For a duration of 1 day you can't use a
> calender without a standard base...
> It's not a static? It should be!

Ok, I'll change that.

> If you feel confident you can work on your own on this (I'll happy still
> help you if you want!) then you can work directly in CVS, I'll just take a
> look at the sources from time to time :)
> Otherwise; sent me the diffs from current CVS and if ok, i'll commit.

I'll just commit directly to cvs unless I'm uncertain about something then. I 
can also send you the patches when I commit them, so you can see what I'm 
doing but without me waiting for you to accept the commit?

Bo.

-- 

     Bo Thorsen                 |   Praestevejen 4
     Free software developer    |   5290 Marslev
     SuSE Labs                  |   Denmark
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]