[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Presentation Duration (for KPresenter)
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-02-19 13:57:20
[Download RAW message or body]

On Friday 15 February 2002 09:40, Toshitaka Fujioka wrote:
> Hi,
> 
> I read a KPresenter's document two days ago and found
> "Chapter 9. Questions and Answers
> [snip]
>   Timing. Some software includes a stopwatch function to allow you to rehearse
>   your presentation and see how long it takes. Buy a clock with a second hand, 
>   note your start and end times. The clock will also be useful for telling the
>   time.
> [snip]
> "
> 
> Werner said that this feature was needless previously (ten months ago).
> I tried to make a new patch.
> Usage of this feature:
> 1. check "Screen Presentations -> Configure Pages... -> Show Presentation
>    Duration"
> 2. start screen presentation.
> 
> Is this feature necessary or needless ?  Comment ?
> I think that this feature is convenience.
> 
> I attached a patch and screen shot. Please review.

Please use KLocale to format time data.
+ return presentationDurationString.sprintf( "%02d:%02d:%02d", hours, minutes, seconds );
looks very hardcoded, in terms of format, whereas KLocale::formatTime does the right thing.
The rest of the code in that method could be simplified, no need for special cases
for _time < 60. The % and / operators will do the right thing on a number smaller than 60.

I also wonder if it was necessary to store the total duration in a member
variable, instead of calculating it by iterating over the list when displaying
the dialog ? Memory saving is always a good thing to do.
(I'm talking about the QTime m_presentationTotalDuration member variable).

+void KPPresDurationDia::resizeEvent( QResizeEvent *e )
+{
+    KDialogBase::resizeEvent( e );
+}
doesn't look very useful ;)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david, http://www.konqueror.org
KDE 3.0: Konquering the Desktops


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]