[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch: (preliminary) fix for #31732
From:       Emmanuel Touzery <emmanuel.touzery () wanadoo ! fr>
Date:       2002-01-15 22:46:05
[Download RAW message or body]

Le Tuesday 15 January 2002 23:34, vous avez écrit :
> we would need an additionnal method commit() or apply() to do the actual
> m_doc->addCommand(), that's what i meant when i talked about breaking code.
> that would be unnatural to type edit->setBold();edit->apply(); just for
> normal text. but i think you thought about that and there's something i
> missed in that part of sentence i didn't get.
> otherwise i'm happy to do the changes as long as it doesn't break too many
> things (ie in kpresenter and all).

or we could make
KCommand *setBold(bool applyCommand=true)

i prefer that idea. of course, that's unless you have already a better one. 
when call with false, it would not do the m_doc->addCommand(). and it would 
not break kpresenter code and still look quite natural. there's also the 
possibility to add setBoldCommand and setBold that uses it.

emmanuel.
-- 
"Give me a lever long enough and a place to stand, and I'll move the world."
	--Archimedes
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]