[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Time Variable Format
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-12-24 9:25:33
[Download RAW message or body]

On Mon, Dec 24, 2001 at 04:50:09AM +0100, Tomasz Grobelny wrote:
> The attached patch  adds a possibility to specify format of time variable. As 
> it is my first patch sent here it is propably not perfect. I'd like to see 
> your comments before I continue my work.

I think it looks quite good! surely a nice addition to KOffice; thanx!!
I have no idea if you have rights to commit; but I'll commit your work now
so its in CVS, as I like the work :)

Feature request; save the format strings used in the kofficerc config and fill
the dialog with the last 5 or 10 or something.
Oh; in that case; it would probably be nicer if the Locale option is the top-most
entry in the dialog (setting the combo to use the 2nd option at default)

> Possible problems:
> 1. What should be the parent of my dialog?
Thats OK.

> 2. Is it the right place to store format information?

I think it is; but maybe the save routing could be adjusted to not store
the information we don't need.
Or did you plan to add a content-sensitive popup to edit the formatting
data?

> 3. Is it the right format to send patches?
Almost; we mostly use 
  diff -u -3 -p -d -b
as that produces the most readable output.


Now for a question to someone with more experience in i18n stuff; the 
dialog that uic creates has a lot of strings like 
    tr2i18n( "Locale" )
will that be translated like it should?

-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]