[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: An internationalization patch of KSpread and KChart
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-11-26 17:01:19
[Download RAW message or body]

On Sunday 26 November 2000 07:51, Toshitaka Fujioka wrote:
> Hello.
>=20
> Two patches attaching are patches to internationalize (Japanese,
> Chinese, Korean etc.) KSpread and KChart.

[Attachment #2 (application/gzip)]
This one may contain useful things, but when I see
   {
       QString tmp( "Document%1" );
       tmp = tmp.arg( s_docId++ );
-      setName( tmp.latin1() );
+      setName( tmp.local8Bit() );
   }
This looks to me like a search and replace of latin1 to something else, maybe
a bit blindly :-)

-    double money = locale()->readMoney(m_strText, &m_bValue);
+    double money = locale()->readMoney(m_strText.utf8(), &m_bValue);
Why this, for instance ?? ReadMoney takes a QString, why send utf8 to it ??

I'm not much in favour of this patch as it is, it looks quite untested to me.

Parts of it look right, though (removing local8Bit from kdDebug calls, removing
.latin1() in places where a QString is expected, the XIM line, etc.)
Laurent, can you have a look and integrate those ?

[Attachment #4 (text/plain)]


kchart has already been extensively i18n-fixed in CVS.
If you could test the HEAD branch and confirm it works, I could backport
the changes to the branch for the 2.0.1 release.
Thanks.

--=20
David FAURE, david@mandrakesoft.com, faure@kde.org
http://www.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2


[prev in list] [next in list] [prev in thread] [next in thread]