[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: dif: strange focus behavior while using pager
From:       Vojtech Bubnik <bubnikv () suse ! cz>
Date:       2000-09-08 11:34:05
[Download RAW message or body]

On Fri, Sep 08, 2000 at 11:17:59AM +0100, David Faure wrote:
> On Fri, 08 Sep 2000, Vojtech Bubnik wrote :
> 
> >Here is the patch.
> 
> Our mails crossed :)
> 
> I prefer mine, because it's smaller (no need for a method in Part in fact), 
> and because it respects some tests that your patch skips, like the test for
> if ( !d->m_managedTopLevelWidgets.containsRef( w->topLevelWidget() ) )
> 

David, I have two objections:

1) focus event should not be stopped, therefore handling if FocusIn should end up
   by 'return false'

2) IMHO FocusIn should only activate the part, not select or deactivate, as it
   is handled now. When policy is TriState, it could do weierd things.

I would modify it like this:

      if ( d->m_policy == PartManager::TriState )

to

      if ( d->m_policy == PartManager::TriState && ev->type() != QEvent::FocusIn )

It should be sufficient to solve both problems.


I am not sure if I am subscribed to koffice-devel. So I am sending this e-mail to 
the old koffice list. I am working on subscribing there.
-- 

Regards, 

Vojtech Bubnik
developer
---------------------------------------------------------------------
SuSE CR, s.r.o.                               e-mail: bubnikv@suse.cz
Pod Pekarnami 338/12                          tel:+420 2 6603 2619
190 00 Praha 9 - Vysocany                     fax:+420 2 6603 2620
Czech Republic                                http://www.suse.cz

[prev in list] [next in list] [prev in thread] [next in thread]