On Sun, Jan 30, 2000 at 09:15:57PM +0100, Werner Trobin wrote:
> David Faure wrote:
> > 
> > On Sun, Jan 30, 2000 at 06:06:11PM +0100, Werner Trobin wrote:
> > > David Faure wrote:
> > > >
> > > > On Sun, Jan 30, 2000 at 11:49:00AM +0100, CVS by wtrobin wrote:
> > > > >
> > > > > koffice/filters HOWTO,1.2,1.3
> > > > > Author: wtrobin
> > > > > CVSROOT: /home/kde
> > > > > Sun Jan 30 11:48:59 MET 2000
> > > > > Update of /home/kde/koffice/filters
> > > > > In directory zeus:/tmp/cvs-serv2112
> > > > >
> > > > > Modified Files:
> > > > >       HOWTO
> > > > > Log Message:
> > > > > - Improved the CSV dialog
> > > > > - Added information to the HOWTO file
> > > > >
> > > > > David: Please have a look - it works now :) (Note: you have to comment
> > > > > out the last line from configure.in.in and recompile koffice to use
> > > > > the KFD...)
> > > >
> > > > Wow, it works indeed :-)
> > >
> > > It was an awful bug :)
> > >
> > > > A few comments on the user interface : instead of the default
> > > > preview widget (the one with a pushbutton and boring text, for the user),
> > > > can't the preview widget be simply blank, hidden, or sized to 0, when
> > > > there is nothing to show ?
> 
> Done. Did I already say that Qt is terrific?

You are terrific :-)
It looks great now !

> > > > Also the CSV dialog should read
> > > > semi-colon (;)
> > > > comma (,)
> > > > tab
> > > > instead of specifying countries...
> > >
> 
> Done.

Great, thanks !

> > > I thought I add that as a hint for the user.
> > 
> > Well, getting it right is very complex. A lot of countries use
> > one or the other, and the real problem isn't the country you're in,
> > but the version of the program you're using. Plus the bugs
> > it can have (Applix has some...). Better just avoid the issue.
> > The real good thing to do, as we said earlier, would be to show
> > a real preview, much like Excel's text-file import dialog.
> 
> Hmmm... I'll think about that :)

That's where it's going to be even more interesting, heh ? :-))

You mentionned using a part for that - in this case let's wait for
(or contribute to) the switch to the new kparts.
After that it should be possible to use a KSpread part in read-only mode,
and embed it into the dialog, below the radio-buttons, start the filter,
and display the converted file in there.

Waiting for that, the conversion should be speeded up. I wonder
why it takes so much time to save a DOM tree to a file (root->save(t)
in xmltree.cc). It looks related to UTF-8 encoding (see my comment
in the file), but I'm not sure where the bug actually is.

It looks like a QDom bug though... when I have time (i.e. never) I'll make
a test program for that and send it to Torben :-)

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today