[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    [Bug 187681] shape shadows are not handled correctly
From:       Jan Hambrecht <jaham () gmx ! net>
Date:       2009-03-24 23:22:05
Message-ID: 20090324232205.F164415CAF () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=187681





--- Comment #6 from Jan Hambrecht <jaham gmx net>  2009-03-25 00:22:04 ---
(In reply to comment #5)
> On Sunday 22. March 2009 15.19.10 Jan Hambrecht wrote:
> > > * You get overlapping shapes painting their shadows on top of each other.
> > > I expect the border to be below all shapes. See the green shape being
> > > covered by a shadow. It should not be.
> >
> > I think it is correct if they have different z-indeces.
> 
> I think it depends on how the user views the z-indeces on the objects.
> The itemviews people got lots of bugreports when they took this approach and 
> basically I think it depends on what your goal is.

Well OOo takes the same approach as we do now, so when changing that you risk
getting bugreports from users on the different shadow behaviour in odf files.
Not sure which the preferred bug reports are. ;-)

> If your goal is to illustrate the fact that one shape has a z-index higher than
> another, then yes.
> But we do our best to hide this fact and actually our code assumes that the 
> user is not affected by z-indexes much.

I don't know how you want to hide the concept of the z-index as that is
inherently present in our painting code.

> 
> Imagine us inserting 2 objects. One after the other.  We place them next to 
> each other.  The user never choose which one is over the other and frankly 
> doesn't care.  But in our code we force one to be above the other because we
> auto-assign them indices.
> If we then end up casting a shadow of one object on the other that is next to 
> it, then that breaks the illusion of them being next to each other.
> In effect we are showing an implementation detail.

Right it is an illusion, which gets destroyed as soon as you have these two
shapes overlap. As i already said, i agree that two shape having the same
z-index should not cast a shadow on each other.

> 
> Maybe we should have a shadow per layer, but I think that its wrong to have one
> per shape that cast a shadow on another shape.
Do you mean a shape layer or a z-index-layer" ?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
____________________________________
koffice mailing list
koffice@kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice
[prev in list] [next in list] [prev in thread] [next in thread]