[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    [Bug 85567] KOffice's named colours are different from kdelibs
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-09-03 13:34:17
Message-ID: 20040903133417.9505.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=85567        




------- Additional Comments From nicolasg snafu de  2004-09-03 15:34 -------
That email should have been forwarded to bug #85567, as it contains some 
important information.

The whole thread is archived at:
http://lists.kde.org/?t=109111327600001&r=1&w=2

Have a nice day!

----------  Forwarded Message  ----------

Subject: Re: Bug 85567 : color names. Need guidance
Date: Thursday 29 July 2004 22:26
From: Nicolas Goutte <nicolasg snafu de>
To: For developer's discussion about KOffice <koffice-devel mail kde org>

On Thursday 29 July 2004 20:24, p.stirnweiss_koffice bluewin ch wrote:
> >-- Message original --
>
> From: Nicolas Goutte <nicolasg snafu de>
>
> >To: For developer's discussion about KOffice <koffice-devel mail kde org>
> >Date: Thu, 29 Jul 2004 20:02:57 +0200
> >Subject: Re: Bug 85567 : color names. Need guidance
> >Reply-To: For developer's discussion about KOffice
> > <koffice-devel mail kde org>
> >
> >On Thursday 29 July 2004 16:58, p.stirnweiss_koffice bluewin ch wrote:
> >> Hello,
> >>
> >> I would like to look at this one also, but I do not understand
> >> everything:
> >>
> >> "
> >> The named colours in KOffice are in
> >> koffice/lib/kofficeui/tkcoloractions.cpp
> >>
> >>  the ones of kdelibs are defined for KDE in
> >> kdelibs/kdeui/colors/colors.cpp
> >>
> >> "

(...)

> >As for the general question about this bug, I do not know. I am wondering
> >if
> >it does not need deeper changes or perhaps even a sort of support from
> >kdelibs.
>
> Indeed, if KWord is already using KDE's color dialog, it makes more sense
> to use it all over the place. Maintenance of it would be done at KDE's
> level (where there is more manpower apparently), and this would be a dream
> for the i18n people. Also it would be more consistent look and feel.

Well, looking at the code of the color chooser, I am not sure if it has so
much manpower, as it still uses functions that are considered potential
security risks (like sscanf), which should not be used in KDE anymore.

But yes, for the translators it has many advantages.

> >In any case, I have realized in the meantime that the name of the colours
> >have
> >a different syntax, so I do not really know what do with it now. (But may
> >be
> >you would have an idea.)
>
> What do you mean by different syntax?

The colors in kdelibs are those of rgb.txt ( /usr/X11R6/lib/X11/rgb.txt , the
file is different for each X-server type and version, so only a part are
really translated.)

The colors selected for translation in rgb.txt are those like "DeepBlue1",
names without spaces, unlike "Deep Blue 1". But KOffice's colors uses names
with spaces.

So a question could be: if one removes the space in the KOffice names, does
that give one of the translated names in kdelibs. If not, is this color at
least in a more recent version of rgb.txt:
http://freedesktop.org/cgi-bin/viewcvs.cgi/xc/programs/rgb/rgb.txt?root=xorg
(again only the names without space count.)

And depending on the answer of the kind of such questions, we could decide
 the best way to use in KOffice. (Not sure if it "Junior" level anymore.)

The last problem is that kdelibs does not define any named gray color, as
indeed gray1 or gray100 is not really intuitive as name.

That is more or less the base of the problem. At code level it is surely a
"Junior" level. But at deciding how to procede perhaps not anymore.

> Pierre

Have a nice day!

> >> Thanks,
> >>
> >> Pierre
> >
> >Have a nice day!
> >
> >> _______________________________________________
> >> koffice-devel mailing list
> >> koffice-devel mail kde org
> >> https://mail.kde.org/mailman/listinfo/koffice-devel
> >
> >_______________________________________________
> >koffice-devel mailing list
> >koffice-devel mail kde org
> >https://mail.kde.org/mailman/listinfo/koffice-devel
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel mail kde org
> https://mail.kde.org/mailman/listinfo/koffice-devel

_______________________________________________
koffice-devel mailing list
koffice-devel mail kde org
https://mail.kde.org/mailman/listinfo/koffice-devel

-------------------------------------------------------
____________________________________
koffice mailing list
koffice@mail.kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice
[prev in list] [next in list] [prev in thread] [next in thread]