[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: [PATCH] Fix table column resizing
From:       David Faure <faure () kde ! org>
Date:       2004-01-16 10:51:10
Message-ID: 200401161151.10641.faure () kde ! org
[Download RAW message or body]

On Friday 12 December 2003 00:06, Sven Langkamp wrote:
> Am Mittwoch, 10. Dezember 2003 00:49 schrieb Sven Langkamp:
> > Am Montag, 8. Dezember 2003 23:14 schrieb Thomas Zander:
> > > Please substitute m_rowPositions.count() with getRows().
> >
> > Ok, changed.
> >
> > I removed row resizing form recalcRows(), so that the first row can be
> > changed too:
> > -            if(lineNumber >= (int)row)  { // below changed row
> > -                if(*(j)-last < s_minFrameHeight) // Never make it smaller
> > then allowed!
> > -                    difference += s_minFrameHeight - *(j) + last;
> > -                last=*(j);
> > -                kdDebug(32004) << "moving " << *(j) << " by " <<
> > difference << "; to " << (*j) + difference << endl;
> > -                (*j) += difference; // move line.
> > -            }
> Sorry, I have posted this patch too early. I didn't mentioned one case.
> I returned to the original patch. Additionally the patch fixes #69170. 
> Can someone review this and tell me if the solution for #69170 ist ok?

I just realized that this patch hadn't been applied yet. Done now.
Do you think this is safe enough to be backported to the 1.3 branch?

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
____________________________________
koffice mailing list
koffice@mail.kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice
[prev in list] [next in list] [prev in thread] [next in thread]