[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: Diff for splitCells (was Re: Diff for join (was Re: Proposal for new table-implementation in KWo
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-10-17 21:30:53
[Download RAW message or body]


On Wed, Oct 17, 2001 at 02:11:35PM +0200, Nash Hoogwater wrote:
> Hi Thomas,
> 
> Well it was easier than I thought it was :-). However I have the same 
> problems with the strange lines from the table. As far as I can see the width 
> of the cells are good, but it just doesn't show good on the screen, but maybe 
> you could shed some light on it :-).

Hi, 

well, you adjusted the recalccols code to do the positioning; I thing you missed
the method position() which solves most of your problems ;)

I removed your changes from the recalcCols method and basically 
the actual fix now comes down to:

@@ -1096,18 +1089,14 @@ KCommand *KWTableFrameSet::joinCells(uns
             }
         }
     }
+
     Q_ASSERT(firstCell);
-    // update firstcell properties te reflect the merge
+    // update firstcell properties to reflect the merge
     firstCell->m_cols=colEnd-colBegin+1;
     firstCell->m_rows=rowEnd-rowBegin+1;
-    kdDebug()<<"=colEnd-colBegin+1; :"<<colEnd-colBegin+1<<endl;
-    kdDebug()<<"=rowEnd-rowBegin+1  :"<<rowEnd-rowBegin+1<<endl;
-    firstCell->getFrame(0)->setRight(right);
-    firstCell->getFrame(0)->setBottom(bottom);
+    position(firstCell);
     firstCell->getFrame(0)->updateResizeHandles();

-    recalcCols();
-    recalcRows();
     m_doc->updateAllFrames();
     m_doc->repaintAllViews();
     return new KWJoinCellCommand( i18n("Join Cells"), this,colBegin,rowBegin, \
colEnd,rowEnd,listFrameSet,listCopyFrame);


I committed this and most of your other code changes (extra spaces at 
the end of the line seem to be common in my coding style :)

Thanx a million!
-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]