[prev in list] [next in list] [prev in thread] [next in thread] 

List:       knode-devel
Subject:    Re: [Knode-devel] KDE/kdepim
From:       Allen Winter <winter () kde ! org>
Date:       2007-09-29 20:35:30
Message-ID: 200709291635.31165.winter () kde ! org
[Download RAW message or body]

On Saturday 29 September 2007 2:08:19 pm Olivier Trichet wrote:
> SVN commit 718793 by otrichet:
> 
> Fix shortcuts for previous/next messages
> 
So shortcuts don't work unless you have whitespace
after a semicolon?  that seems awfully brittle.
I seem to recall a discussion on k-c-d about this
and I thought we agreed requiring whitespace 
was too restrictive?? 

> 
>  M  +2 -2      kmail/kmmainwidget.cpp  
>  M  +2 -2      knode/knmainwidget.cpp  
> 
> 
> --- trunk/KDE/kdepim/kmail/kmmainwidget.cpp #718792:718793
> @@ -3290,7 +3290,7 @@
>    {
>      QAction *action = new KAction(i18n("&Next Message"), this);
>      actionCollection()->addAction("go_next_message", action );
> -    action->setShortcuts(KShortcut( "N;Right" ));
> +    action->setShortcuts(KShortcut( "N; Right" ));
>      action->setToolTip(i18n("Go to the next message"));
>      connect(action, SIGNAL(triggered(bool) ), SLOT(slotNextMessage()));
>    }
> @@ -3312,7 +3312,7 @@
>      QAction *action = new KAction(i18n("&Previous Message"), this);
>      actionCollection()->addAction("go_prev_message", action );
>      action->setToolTip(i18n("Go to the previous message"));
> -    action->setShortcuts(KShortcut( "P;Left" ));
> +    action->setShortcuts(KShortcut( "P; Left" ));
>      connect(action, SIGNAL(triggered(bool) ), SLOT(slotPrevMessage()));
>    }
>    {
> --- trunk/KDE/kdepim/knode/knmainwidget.cpp #718792:718793
> @@ -543,13 +543,13 @@
>    a_ctNavNextArt->setIcon(KIcon("find-next"));
>    a_ctNavNextArt->setText(i18n("&Next Article"));
>    a_ctNavNextArt->setToolTip(i18n("Go to next article"));
> -  a_ctNavNextArt->setShortcuts(KShortcut("N;Right"));
> +  a_ctNavNextArt->setShortcuts(KShortcut("N; Right"));
>    connect(a_ctNavNextArt, SIGNAL(triggered(bool)), h_drView, SLOT(nextArticle()));
>  
>    a_ctNavPrevArt = actionCollection()->addAction("go_prevArticle" );
>    a_ctNavPrevArt->setIcon(KIcon("find-previous"));
>    a_ctNavPrevArt->setText(i18n("&Previous Article"));
> -  a_ctNavPrevArt->setShortcuts(KShortcut("P;Left"));
> +  a_ctNavPrevArt->setShortcuts(KShortcut("P; Left"));
>    a_ctNavPrevArt->setToolTip(i18n("Go to previous article"));
>    connect(a_ctNavPrevArt, SIGNAL(triggered(bool)), h_drView, SLOT(prevArticle()));
>  
> 



-- 
KDEPIM Developer
I accept PayPal payments to awinterz@earthlink.net
_______________________________________________
Knode-devel mailing list
Knode-devel@kde.org
https://mail.kde.org/mailman/listinfo/knode-devel
[prev in list] [next in list] [prev in thread] [next in thread]