[prev in list] [next in list] [prev in thread] [next in thread] 

List:       knode-devel
Subject:    [Knode-devel] [Bug 64830] Crash when opening headers view
From:       Roberto Teixeira <maragato () kde ! org>
Date:       2003-10-18 19:33:37
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
     
http://bugs.kde.org/show_bug.cgi?id=64830     
maragato@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From maragato@kde.org  2003-10-18 21:33 -------
Subject: kdepim/knode

CVS commit by maragato: 

Doesn't crash when trying to show the header view while the article view was closed.

CCMAIL: 64830-done@bugs.kde.org


  M +10 -7     knmainwidget.cpp   1.13


--- kdepim/knode/knmainwidget.cpp  #1.12:1.13
@@ -1411,12 +1411,6 @@ void KNMainWidget::slotCheckDockWidgetSt
 {
   a_ctToggleGroupView->setChecked(c_olDock->isVisible());
-  a_ctToggleHeaderView->setChecked(h_drDock->isVisible());
   a_ctToggleArticleViewer->setChecked(a_rtDock->isVisible());
-  a_ctToggleGroupView->setChecked( c_olDock->isVisible() );
-  a_ctToggleGroupView->setEnabled(  c_olDock->isDockBackPossible() );
-  a_ctToggleHeaderView->setChecked( h_drDock->isVisible() );
-  a_ctToggleHeaderView->setEnabled( h_drDock->isDockBackPossible() );
-  a_ctToggleArticleViewer->setChecked(a_rtDock->isVisible() );
-  a_ctToggleArticleViewer->setEnabled( a_rtDock->isDockBackPossible() );
+  a_ctToggleHeaderView->setChecked(h_drDock->isVisible());
 }
 
@@ -2246,4 +2240,13 @@ void KNMainWidget::slotToggleGroupView()
 void KNMainWidget::slotToggleHeaderView()
 {
+
+  if ( !h_drDock->isVisible() )
+      if ( !h_drDock->isDockBackPossible() ) {
+          h_drDock->manualDock( a_rtDock, KDockWidget::DockTop );
+          h_drDock->makeDockVisible();
+          slotCheckDockWidgetStatus();
+          return;
+      }
+
   h_drDock->changeHideShowState();
   slotCheckDockWidgetStatus();
[prev in list] [next in list] [prev in thread] [next in thread]