[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: Review Request 128624: Rewrite processQIFLine
From: Cristian_Oneț <onet.cristian () gmail ! com>
Date: 2016-08-09 15:23:31
Message-ID: 20160809152331.9365.36576 () mimi ! kde ! org
[Download RAW message or body]
--===============7535578110373806145==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128624/#review98230
-----------------------------------------------------------
kmymoney/plugins/csvimport/csvdialog.h (line 64)
<https://git.reviewboard.kde.org/r/128624/#comment66167>
Why don't you name the enum and use the type everywhere that you added 'uchar' \
now?
- Cristian Oneț
On Aug. 7, 2016, 3:40 p.m., Łukasz Wojniłowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128624/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2016, 3:40 p.m.)
>
>
> Review request for KMymoney.
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> 1) processQIFLine should identify fields by integers and not strings (better \
> performance), 2) validation of debit and credit column contained unnecessary check \
> and was complicated, 3) QIF creation is not essential to processing,
> 4) statements is not needed and consumed memory exponentially,
> 5) cleaner hash assignation,
> 6) lots of redundant variables.
>
> createMemoField is commented for now but won't be after I rewrite \
> processInvestLine.
>
> Diffs
> -----
>
> kmymoney/plugins/csvimport/csvdialog.h 65bbeb7
> kmymoney/plugins/csvimport/csvdialog.cpp 6d91d63
> kmymoney/plugins/csvimport/csvwizard.h 2743685
> kmymoney/plugins/csvimport/csvwizard.cpp b042a98
>
> Diff: https://git.reviewboard.kde.org/r/128624/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Łukasz Wojniłowicz
>
>
--===============7535578110373806145==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128624/">https://git.reviewboard.kde.org/r/128624/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128624/diff/1/?file=473702#file473702line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/plugins/csvimport/csvdialog.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">69</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QStringList</span> <span class="n">m_shrsinList</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">64</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span \
class="p">{</span> <span class="n">Column_Number</span><span class="p">,</span> <span \
class="n">Column_Date</span><span class="p">,</span> <span \
class="n">Column_Payee</span><span class="p">,</span> <span \
class="n">Column_Amount</span><span class="p">,</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
don't you name the enum and use the type everywhere that you added 'uchar' \
now?</p></pre> </div>
</div>
<br />
<p>- Cristian Oneț</p>
<br />
<p>On August 7th, 2016, 3:40 p.m. UTC, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2016, 3:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1) processQIFLine should identify fields by integers \
and not strings (better performance), 2) validation of debit and credit column \
contained unnecessary check and was complicated, 3) QIF creation is not essential to \
processing, 4) statements is not needed and consumed memory exponentially,
5) cleaner hash assignation,
6) lots of redundant variables.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">createMemoField is commented for now but won't be \
after I rewrite processInvestLine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: \
grey">(65bbeb7)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: \
grey">(6d91d63)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: \
grey">(2743685)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: \
grey">(b042a98)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128624/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7535578110373806145==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic