[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request 114767: Add ability to modify loan institution attribute.
From: "Alvaro Soliverez" <asoliverez () kde ! org>
Date: 2014-01-13 15:52:06
Message-ID: 20140113155206.17947.57626 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114767/#review47323
-----------------------------------------------------------
The patch looks ok to me, except for the debug statements.
Thomas, are you ok with it to commit?
kmymoney/wizards/newloanwizard/keditloanwizard.cpp
<https://git.reviewboard.kde.org/r/114767/#comment33709>
Remember to remove the debug statements and includes before pushing
- Alvaro Soliverez
On Jan. 3, 2014, 11:27 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114767/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 11:27 p.m.)
>
>
> Review request for KMymoney.
>
>
> Bugs: 257619
> http://bugs.kde.org/show_bug.cgi?id=257619
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> Add ability to modify loan institution attribute.
>
> Add a new choice to editselectionwizardpage to modify only loan attributes.
> Add a new loanattributes page to modify just institution for now, will add other \
> attributes next.
> BUG:257619
> REVIEW:114767
>
>
> Diffs
> -----
>
> kmymoney/wizards/newloanwizard/CMakeLists.txt \
> 939d569c2bba56ccfd3c9d6b28f8b90d414b9332 \
> kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp \
> e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5 \
> kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui \
> 2e482c47f9a3642a880f0dcb047ca577c6e0446c \
> kmymoney/wizards/newloanwizard/keditloanwizard.cpp \
> 5590a359ffc16c92fc3dc24b6484aac1180b1507 \
> kmymoney/wizards/newloanwizard/knewloanwizard.h \
> 6b3f049912605f4f9cb0e78ee83b14e2767586b8 \
> kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui \
> 831d85ce388b51a904c76cd998f54ca6a099b347 \
> kmymoney/wizards/newloanwizard/loanattributeswizardpage.h PRE-CREATION \
> kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp PRE-CREATION \
> kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui PRE-CREATION
> Diff: https://git.reviewboard.kde.org/r/114767/diff/
>
>
> Testing
> -------
>
> It works here to set and to show the current institution.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114767/">https://git.reviewboard.kde.org/r/114767/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch looks ok to \
me, except for the debug statements.
Thomas, are you ok with it to commit?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114767/diff/3/?file=229785#file229785line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/wizards/newloanwizard/keditloanwizard.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <QtDebug></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remember to \
remove the debug statements and includes before pushing</pre> </div>
<br />
<p>- Alvaro Soliverez</p>
<br />
<p>On January 3rd, 2014, 11:27 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2014, 11:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257619">257619</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add ability to modify loan institution attribute.
Add a new choice to editselectionwizardpage to modify only loan attributes.
Add a new loanattributes page to modify just institution for now, will add other \
attributes next.
BUG:257619
REVIEW:114767</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works here to set and to show the current institution.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/wizards/newloanwizard/CMakeLists.txt <span style="color: \
grey">(939d569c2bba56ccfd3c9d6b28f8b90d414b9332)</span></li>
<li>kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp <span style="color: \
grey">(e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5)</span></li>
<li>kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui <span \
style="color: grey">(2e482c47f9a3642a880f0dcb047ca577c6e0446c)</span></li>
<li>kmymoney/wizards/newloanwizard/keditloanwizard.cpp <span style="color: \
grey">(5590a359ffc16c92fc3dc24b6484aac1180b1507)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizard.h <span style="color: \
grey">(6b3f049912605f4f9cb0e78ee83b14e2767586b8)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui <span style="color: \
grey">(831d85ce388b51a904c76cd998f54ca6a099b347)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpage.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114767/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic