From kmymoney-devel Wed Oct 02 05:36:18 2013 From: "Ralf Habacker" Date: Wed, 02 Oct 2013 05:36:18 +0000 To: kmymoney-devel Subject: Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and Message-Id: <20131002053618.19487.84062 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kmymoney-devel&m=138069221505397 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4431590211275784661==" --===============4431590211275784661== Content-Type: multipart/alternative; boundary="===============5814368439538298900==" --===============5814368439538298900== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Sept. 21, 2013, 4:24 p.m., Alvaro Soliverez wrote: > > I fail to see why you would want equity accounts displayed for imports. Can you explain the use case? > > > > Keep in mind that equity accounts are not stock or share accounts of some kind. To be able to import opening balances for example when using german template "all accounts", which have an account "Equity"->"Opening balances". Otherwise I would have to manual enter the opening balances for all related accounts by hand. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112847/#review40403 ----------------------------------------------------------- On Sept. 21, 2013, 2:41 p.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112847/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2013, 2:41 p.m.) > > > Review request for KMymoney and Cristian OneČ›. > > > Repository: kmymoney > > > Description > ------- > > When enabled display of equity accounts with 'settings->general->filter->show equity accounts' equity accounts are not displayed in the "Default Account" tab of payee page and in the unknown payee import dialog. > > The related bug could be triggered with: > 1. create a new file > 2. select the german skr03 standard chart of accounts. > > > Diffs > ----- > > kmymoney/converter/mymoneystatementreader.cpp 5619cc2 > kmymoney/views/kgloballedgerview.cpp 2057b47 > kmymoney/views/kpayeesview.cpp 69697e6 > > Diff: http://git.reviewboard.kde.org/r/112847/diff/ > > > Testing > ------- > > git master > > > Thanks, > > Ralf Habacker > > --===============5814368439538298900== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112847/

On September 21st, 2013, 4:24 p.m. CEST, Alvaro Soliverez wrote:

I fail to see why you would want equity accounts displayed for imports. Can you explain the use case?

Keep in mind that equity accounts are not stock or share accounts of some kind.
To be able to import opening balances for example when using german template "all accounts", which have an account "Equity"->"Opening balances". Otherwise I would have to manual enter the opening balances for all related accounts by hand.

- Ralf


On September 21st, 2013, 2:41 p.m. CEST, Ralf Habacker wrote:

Review request for KMymoney and Cristian OneČ›.
By Ralf Habacker.

Updated Sept. 21, 2013, 2:41 p.m.

Repository: kmymoney

Description

When enabled display of equity accounts with 'settings->general->filter->show equity accounts' equity accounts are not displayed in the "Default Account" tab of payee page and in the unknown payee import dialog. 

The related bug could be triggered with: 
1. create a new file
2. select the german skr03 standard chart of accounts. 

Testing

git master

Diffs

  • kmymoney/converter/mymoneystatementreader.cpp (5619cc2)
  • kmymoney/views/kgloballedgerview.cpp (2057b47)
  • kmymoney/views/kpayeesview.cpp (69697e6)

View Diff

--===============5814368439538298900==-- --===============4431590211275784661== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel --===============4431590211275784661==--