[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request 112947: BUG:322768 - Interest category and amount disappear when
From: Cristian_Oneț <onet.cristian () gmail ! com>
Date: 2013-10-02 4:31:09
Message-ID: 20131002043109.12750.76601 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/#review41094
-----------------------------------------------------------
kmymoney/dialogs/transactioneditor.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30161>
Why are you undoing this change I've made some days ago? \
https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/092f3a79f4ec74d25e0f5a4b9c80dfef64db5da3
Are you sure that you have the patch against master?
kmymoney/widgets/kmymoneydateinput.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30162>
This is part of a patch I posted for review, again are you sure that you have in \
this patch only your changes against master? \
https://git.reviewboard.kde.org/r/112989/
kmymoney/widgets/register.h
<http://git.reviewboard.kde.org/r/112947/#comment30163>
Belongs to https://git.reviewboard.kde.org/r/112989/
kmymoney/widgets/register.cpp
<http://git.reviewboard.kde.org/r/112947/#comment30164>
All the changes to this file belong to https://git.reviewboard.kde.org/r/112989/
It seems that there was a problem in the way you created the new patch. You mixed in \
some other patches and undid some recents commits with it so it can't be shipped \
unless you fix that.
- Cristian Oneț
On Oct. 1, 2013, 7:33 p.m., Allan Anderson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112947/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 7:33 p.m.)
>
>
> Review request for KMymoney.
>
>
> Bugs: 322768
> http://bugs.kde.org/show_bug.cgi?id=322768
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> - Interest category disappears -
> Steps to Reproduce:
> 1.Open a new Dividend transaction.
> 2.Enter an interest category and amount.
> 3.Enter a new fee category.
> 4.On accepting the new category, the interest category and amount have been \
> cleared. One line fix in kmymoney/dialogs/transactioneditor.cpp.
>
> - Fixes for KEditWidget visibility issues.
> When editing an investment transaction, interest or fee edit widgets show or hide \
> incorrectly. This is a fairly long-standing issue, and there have been attempts to \
> fix by delaying the show() or hide() instructions. This became more pronounced \
> during work to allow column resizing, and Cristian produced a fix for the root \
> cause. This fix is included here. With the above fix in place, it became necessary \
> to revert the delayed show() and hide() calls, and this has been done. Of course, \
> nothing is ever as simple as that, and another couple of issues emerged. Whether \
> or not an interest or fee amount widget is shown depends on the presence or absence \
> of the associated category's text. It transpired that if, say, an existing \
> Reinvest transaction was edited to be, say a Buy transaction, the text from the \
> Reinvest interest category was seen by the new Buy entry and resulted in the \
> interest-amount widget being visible when none should appear. Similarly, if a \
> transaction with a fee set is edited to be a type with no fee expected, for \
> instance, an Add or RemoveShares, then the fee-amount widget became visible when \
> not needed. It was necessary to rework the slotUpdateFeeVisibility() and \
> slotUpdateInterestVisibility() functions to take account of the new transaction \
> type.
>
> Diffs
> -----
>
> kmymoney/dialogs/investactivities.cpp 50f33ed
> kmymoney/dialogs/investtransactioneditor.h 3e62c2a
> kmymoney/dialogs/investtransactioneditor.cpp e9f87fb
> kmymoney/dialogs/transactioneditor.cpp cfb0f71
> kmymoney/widgets/kmymoneydateinput.cpp 856efaa
> kmymoney/widgets/register.h 50ce759
> kmymoney/widgets/register.cpp d5dd639
> kmymoney/widgets/transactioneditorcontainer.h f77b195
> kmymoney/widgets/transactionform.cpp 642e98f
>
> Diff: http://git.reviewboard.kde.org/r/112947/diff/
>
>
> Testing
> -------
>
> Entering and editing various transaction types to ensure only the appropriate \
> widgets became visible or hidden when required.
>
> Thanks,
>
> Allan Anderson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112947/">http://git.reviewboard.kde.org/r/112947/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112947/diff/2/?file=193217#file193217line1402" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/dialogs/transactioneditor.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StdTransactionEditor::autoFill(const QString& payeeId)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1402</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p"><span class="hl">(</span>(</span><span \
class="n">s</span><span class="p">.</span><span class="n">accountId</span><span \
class="p">()</span> <span class="o">!=</span> <span class="n">m_account</span><span \
class="p">.</span><span class="n">id</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">t</span><span class="p">.</span><span \
class="n">splitCount</span><span class="p">()</span> <span class="o">==</span> <span \
class="mi">2</span><span class="p">)</span><span class="hl"> </span><span \
class="o"><span class="hl">||</span></span><span class="hl"> </span><span \
class="o"><span class="hl">!</span></span><span class="n"><span \
class="hl">KMyMoneyGlobalSettings</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">autoFillUseMemos</span></span><span class="p"><span clas \
s="hl">())</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1401</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">s</span><span class="p">.</span><span \
class="n">accountId</span><span class="p">()</span> <span class="o">!=</span> <span \
class="n">m_account</span><span class="p">.</span><span class="n">id</span><span \
class="p">()</span> <span class="o">&&</span> <span class="n">t</span><span \
class="p">.</span><span class="n">splitCount</span><span class="p">()</span> <span \
class="o">==</span> <span class="mi">2</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why are you \
undoing this change I've made some days ago? \
https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/092f3a79f4ec74d25e0f5a4b9c80dfef64db5da3
Are you sure that you have the patch against master?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112947/diff/2/?file=193218#file193218line229" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/widgets/kmymoneydateinput.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
kMyMoneyDateInput::fixSize(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">229</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
part of a patch I posted for review, again are you sure that you have in this patch \
only your changes against master? https://git.reviewboard.kde.org/r/112989/</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112947/diff/2/?file=193219#file193219line575" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/widgets/register.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">575</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="cm">/**</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Belongs to \
https://git.reviewboard.kde.org/r/112989/</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112947/diff/2/?file=193220#file193220line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/widgets/register.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <KPushButton></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the \
changes to this file belong to https://git.reviewboard.kde.org/r/112989/</pre> </div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems that there was \
a problem in the way you created the new patch. You mixed in some other patches and \
undid some recents commits with it so it can't be shipped unless you fix \
that.</pre>
<p>- Cristian Oneț</p>
<br />
<p>On October 1st, 2013, 7:33 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2013, 7:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322768">322768</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Interest category disappears - Steps to Reproduce:
1.Open a new Dividend transaction.
2.Enter an interest category and amount.
3.Enter a new fee category.
4.On accepting the new category, the interest category and amount have been cleared.
One line fix in kmymoney/dialogs/transactioneditor.cpp.
- Fixes for KEditWidget visibility issues.
When editing an investment transaction, interest or fee edit widgets show or hide \
incorrectly. This is a fairly long-standing issue, and there have been attempts to \
fix by delaying the show() or hide() instructions. This became more pronounced \
during work to allow column resizing, and Cristian produced a fix for the root cause. \
This fix is included here. With the above fix in place, it became necessary to revert \
the delayed show() and hide() calls, and this has been done. Of course, nothing is \
ever as simple as that, and another couple of issues emerged. Whether or not an \
interest or fee amount widget is shown depends on the presence or absence of the \
associated category's text. It transpired that if, say, an existing Reinvest \
transaction was edited to be, say a Buy transaction, the text from the Reinvest \
interest category was seen by the new Buy entry and resulted in the interest-amount \
widget being visible when none should appear. Similarly, if a transaction with a fee \
set is edited to be a type with no fee expected, for instance, an Add or \
RemoveShares, then the fee-amount widget became visible when not needed. It was \
necessary to rework the slotUpdateFeeVisibility() and slotUpdateInterestVisibility() \
functions to take account of the new transaction type.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Entering and editing various transaction types to ensure only the \
appropriate widgets became visible or hidden when required.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/investactivities.cpp <span style="color: \
grey">(50f33ed)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.h <span style="color: \
grey">(3e62c2a)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.cpp <span style="color: \
grey">(e9f87fb)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: \
grey">(cfb0f71)</span></li>
<li>kmymoney/widgets/kmymoneydateinput.cpp <span style="color: \
grey">(856efaa)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(50ce759)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(d5dd639)</span></li>
<li>kmymoney/widgets/transactioneditorcontainer.h <span style="color: \
grey">(f77b195)</span></li>
<li>kmymoney/widgets/transactionform.cpp <span style="color: \
grey">(642e98f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112947/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic