[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and
From: "Alvaro Soliverez" <asoliverez () kde ! org>
Date: 2013-09-30 13:31:34
Message-ID: 20130930133134.12632.20435 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 21, 2013, 10:29 a.m., Cristian Oneț wrote:
> > I would wait for Thomas's opinion about this. Strictly from a programmer POV the \
> > patch looks fine, I'm not certain about the functionality, I don't know why the \
> > equity accounts were not available in the ledger until now.
>
> Alvaro Soliverez wrote:
> Equity accounts in KMM are hidden because it's advanced functionality and we try to \
> hide the double-entry accounting as much as possible. Keep in mind that the equity \
> accounts are not assets, or shares in a company, rather the net worth from opening \
> balances in accounts.
> They are hidden in normal mode, and should be hidden.
>
> Cristian Oneț wrote:
> The current patch will only show the equity accounts in those places in expert \
> mode.
> I don't see why the application should limit the kind of accounts unless there is \
> some constraint related with the type of the equity account. If the equity accounts \
> are normal accounts I don't see anything wrong in showing them in expert mode.
Because equity accounts are not normal accounts. Normally, you shouldn't need to \
enter transactions into these accounts. That's how it was for 10+ years. Then the \
accounts were enabled for manual transactions.
I fail to see a use case where you would need to have these accounts set for \
automatic import. I feel these equity accounts are being mistaken by stock accounts \
(which these are not)
- Alvaro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112847/#review40398
-----------------------------------------------------------
On Sept. 21, 2013, 12:41 p.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112847/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2013, 12:41 p.m.)
>
>
> Review request for KMymoney and Cristian Oneț.
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> When enabled display of equity accounts with 'settings->general->filter->show \
> equity accounts' equity accounts are not displayed in the "Default Account" tab of \
> payee page and in the unknown payee import dialog.
> The related bug could be triggered with:
> 1. create a new file
> 2. select the german skr03 standard chart of accounts.
>
>
> Diffs
> -----
>
> kmymoney/converter/mymoneystatementreader.cpp 5619cc2
> kmymoney/views/kgloballedgerview.cpp 2057b47
> kmymoney/views/kpayeesview.cpp 69697e6
>
> Diff: http://git.reviewboard.kde.org/r/112847/diff/
>
>
> Testing
> -------
>
> git master
>
>
> Thanks,
>
> Ralf Habacker
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112847/">http://git.reviewboard.kde.org/r/112847/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 21st, 2013, 10:29 a.m. UTC, \
<b>Cristian Oneț</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;">I would wait for Thomas's opinion about this. Strictly \
from a programmer POV the patch looks fine, I'm not certain about the \
functionality, I don't know why the equity accounts were not available in the \
ledger until now.</pre> </blockquote>
<p>On September 21st, 2013, 2:22 p.m. UTC, <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Equity accounts in KMM \
are hidden because it's advanced functionality and we try to hide the \
double-entry accounting as much as possible. Keep in mind that the equity accounts \
are not assets, or shares in a company, rather the net worth from opening balances in \
accounts.
They are hidden in normal mode, and should be hidden.</pre>
</blockquote>
<p>On September 30th, 2013, 1:22 p.m. UTC, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current patch will \
only show the equity accounts in those places in expert mode.
I don't see why the application should limit the kind of accounts unless there is \
some constraint related with the type of the equity account. If the equity accounts \
are normal accounts I don't see anything wrong in showing them in expert \
mode.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because equity accounts \
are not normal accounts. Normally, you shouldn't need to enter transactions into \
these accounts. That's how it was for 10+ years. Then the accounts were enabled \
for manual transactions.
I fail to see a use case where you would need to have these accounts set for \
automatic import. I feel these equity accounts are being mistaken by stock accounts \
(which these are not)</pre> <br />
<p>- Alvaro</p>
<br />
<p>On September 21st, 2013, 12:41 p.m. UTC, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2013, 12:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When enabled display of equity accounts with \
'settings->general->filter->show equity accounts' equity accounts \
are not displayed in the "Default Account" tab of payee page and in the \
unknown payee import dialog.
The related bug could be triggered with:
1. create a new file
2. select the german skr03 standard chart of accounts.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">git master</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: \
grey">(5619cc2)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: \
grey">(2057b47)</span></li>
<li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(69697e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112847/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic