'Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmymoney-devel
Subject:    Re: [Kmymoney-devel] Review Request 112847: Display equity accounts when enabled in payees page and
From:       "Ralf Habacker" <ralf.habacker () freenet ! de>
Date:       2013-09-20 21:20:51
Message-ID: 20130920212051.13883.15363 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112847/
-----------------------------------------------------------

(Updated Sept. 20, 2013, 11:20 p.m.)

Review request for KMymoney and Cristian Oneț.

Changes
-------

display equity accounts in ledger page

Description
-------

When enabled display of equity accounts with 'settings->general->filter->show equity \
accounts' equity accounts are not displayed in the "Default Account" tab of payee \
page and in the unknown payee import dialog. 

Diffs (updated)
-----

  kmymoney/converter/mymoneystatementreader.cpp 5619cc2 
  kmymoney/views/kgloballedgerview.cpp 2057b47 
  kmymoney/views/kpayeesview.cpp 69697e6 

Diff: http://git.reviewboard.kde.org/r/112847/diff/

Testing
-------

git master

Thanks,

Ralf Habacker

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112847/">http://git.reviewboard.kde.org/r/112847/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Ralf Habacker.</div>

<p style="color: grey;"><i>Updated Sept. 20, 2013, 11:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">display equity accounts in ledger page</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When enabled display of equity accounts with \
&#39;settings-&gt;general-&gt;filter-&gt;show equity accounts&#39; equity accounts \
are not displayed in the &quot;Default Account&quot; tab of payee page and in the \
unknown payee import dialog. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">git master</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: \
grey">(5619cc2)</span></li>

 <li>kmymoney/views/kgloballedgerview.cpp <span style="color: \
grey">(2057b47)</span></li>

 <li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(69697e6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112847/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[prev in list] [next in list] [prev in thread] [next in thread] 