'Re: [Kmymoney-devel] Review Request 112846: Print out unknown payee name on import to give users a h'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmymoney-devel
Subject:    Re: [Kmymoney-devel] Review Request 112846: Print out unknown payee name on import to give users a h
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-20 17:52:11
Message-ID: 20130920175211.11498.46876 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112846/#review40390
-----------------------------------------------------------

This review has been submitted with commit d457739d47a0fd7c767c1ecd400d35a7ce0df736 \
by Ralf Habacker to branch master.

- Commit Hook

On Sept. 20, 2013, 5:52 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112846/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 5:52 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Description
> -------
> 
> When importing transactions with unknown payees kmymoney displays a dialog to let \
> the user choose a related account.  Unfortunally it do not print out the unkown \
> payee name, which makes is hard to choose the right account.  
> This patch fixes this issue by printing the payee name in the mentioned dialog.
> 
> 
> Diffs
> -----
> 
> kmymoney/converter/mymoneystatementreader.cpp eaa3969 
> 
> Diff: http://git.reviewboard.kde.org/r/112846/diff/
> 
> 
> Testing
> -------
> 
> tested on kmymoney git master
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112846/">http://git.reviewboard.kde.org/r/112846/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d457739d47a0fd7c767c1ecd400d35a7ce0df736 by Ralf Habacker to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 20th, 2013, 5:52 p.m. UTC, Ralf Habacker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Ralf Habacker.</div>

<p style="color: grey;"><i>Updated Sept. 20, 2013, 5:52 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When importing transactions with unknown payees kmymoney displays a \
dialog to let the user choose a related account.  Unfortunally it do not print out \
the unkown payee name, which makes is hard to choose the right account. 

This patch fixes this issue by printing the payee name in the mentioned dialog.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested on kmymoney git master</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: \
grey">(eaa3969)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112846/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[prev in list] [next in list] [prev in thread] [next in thread] 