[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request: Some i18n improvements
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2012-12-09 13:25:18
Message-ID: 20121209132518.8054.30620 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103622/
-----------------------------------------------------------
(Updated Dec. 9, 2012, 1:25 p.m.)
Review request for KMymoney.
Changes
-------
Fix one syntax error.
Description
-------
This is the beginning of some work needed to ease translators work. I was l=
ooking into the kmymoney.po file today and found a bunch of issues which I =
reported to the IRC channel and now copy in here:
-then there is a pushbutton labeled "Del", while usually "Delete" is used. =
Using the short form there will not give any benefits, as most translations=
will be longer anyway. Near that "Del" thing are some other very short tex=
ts, like "Upd", "Res", "Ren", and so on. As long as you don't put in a cont=
ext that says the translation must not be longer than 3 characters this eff=
ort on short names is void
-then 'Duplicate' has contexts 'Duplicate transaction' and 'To duplicate a =
split'. I would say the first context will fit the second place, too
-there are 3 occurences of "From" without context, and one with context "Fr=
om (Date)". would be nice if the other 3 could be annotated, too. For stabl=
e branch (if applicable): only annotate those that would get "From (Date)",=
this will not break string freeze
-then there is the tooltip "Select column containing amount field", once wi=
th and once without following dot. one has a context that is the text itsel=
f, the other has none. I suggest using the one with dot and without context
-then there is the text "Select column containing date field", also with an=
d without dot
-the context is "verb, Select column containing number field." which doesn'=
t look useful to me
-there are some more tooltips with the context being "verb, <text of toolti=
p>"
-there are a lot of "Total" with context "Total balance" (which is enough I=
MHO). Then there are 2 with "Total balance for ..." which can be merged in =
the above IMHO
-why are the month names as translatable strings in there, isn't it enough =
to call QDate::longMonthName()?
-kmymoney/plugins/csvimport/lines-datewizardpage.ui:241, 246, 251 have stri=
ngs like "y m d". The translation fuzzy cache shows that such a string prev=
iously existed with the context "abbreviation of 'year', 'month', 'day'". I=
would like to see that context returning.
-there are strings that start or end in whitespace, I'm not sure if that ma=
kes sense at all
I left out some parts of the chat that are already fixed by the attached pa=
tch. Some other lines are rearranged to make reading smoother as related li=
nes are together. Please note that I'll not go to fix up the rest as there =
is additional knowledge needed about the program that I don't have and I do=
n't really have time to go over the whole codebase. I hope this is still va=
lueable for you as it may give you an idea of what needs to be touched.
Diffs (updated)
-----
kmymoney/dialogs/settings/ksettingsregisterdecl.ui 8d99e48 =
kmymoney/kmymoneyutils.cpp 527a77a =
kmymoney/plugins/csvimport/separatorwizardpage.ui f3bd3a9 =
kmymoney/views/kmymoneyview.cpp 818d6ea =
kmymoney/widgets/transaction.cpp 8ef8a94 =
kmymoney/wizards/newaccountwizard/kloanpaymentpagedecl.ui 6b7bf1e =
kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp 37be834 =
kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui 1c7de3e =
Diff: http://git.reviewboard.kde.org/r/103622/diff/
Testing (updated)
-------
Compiles.
Thanks,
Rolf Eike Beer
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103622/">http://git.reviewboard.kde.org/r/103622/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Rolf Eike Beer.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2012, 1:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix one syntax error.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the beginning of some work needed to ease translators work. I \
was looking into the kmymoney.po file today and found a bunch of issues which I \
reported to the IRC channel and now copy in here:
-then there is a pushbutton labeled "Del", while usually "Delete" \
is used. Using the short form there will not give any benefits, as most translations \
will be longer anyway. Near that "Del" thing are some other very short \
texts, like "Upd", "Res", "Ren", and so on. As long as \
you don't put in a context that says the translation must not be longer than 3 \
characters this effort on short names is void
-then 'Duplicate' has contexts 'Duplicate transaction' and 'To \
duplicate a split'. I would say the first context will fit the \
second place, too
-there are 3 occurences of "From" without context, and one with context \
"From (Date)". would be nice if the other 3 could be annotated, too. For \
stable branch (if applicable): only annotate those that would get "From \
(Date)", this will not break string freeze
-then there is the tooltip "Select column containing amount field", once \
with and once without following dot. one has a context that is the text itself, the \
other has none. I suggest using the one with dot and without context
-then there is the text "Select column containing date field", also with \
and without dot
-the context is "verb, Select column containing number field." which \
doesn't look useful to me
-there are some more tooltips with the context being "verb, <text of \
tooltip>"
-there are a lot of "Total" with context "Total balance" (which \
is enough IMHO). Then there are 2 with "Total balance for ..." which can be \
merged in the above IMHO
-why are the month names as translatable strings in there, isn't it enough to \
call QDate::longMonthName()?
-kmymoney/plugins/csvimport/lines-datewizardpage.ui:241, 246, 251 have strings like \
"y m d". The translation fuzzy cache shows that such a string previously \
existed with the context "abbreviation of 'year', 'month', \
'day'". I would like to see that context returning.
-there are strings that start or end in whitespace, I'm not sure if that makes \
sense at all
I left out some parts of the chat that are already fixed by the attached patch. Some \
other lines are rearranged to make reading smoother as related lines are together. \
Please note that I'll not go to fix up the rest as there is additional knowledge \
needed about the program that I don't have and I don't really have time to go \
over the whole codebase. I hope this is still valueable for you as it may give you an \
idea of what needs to be touched.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingsregisterdecl.ui <span style="color: \
grey">(8d99e48)</span></li>
<li>kmymoney/kmymoneyutils.cpp <span style="color: grey">(527a77a)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: \
grey">(f3bd3a9)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(818d6ea)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(8ef8a94)</span></li>
<li>kmymoney/wizards/newaccountwizard/kloanpaymentpagedecl.ui <span style="color: \
grey">(6b7bf1e)</span></li>
<li>kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp <span style="color: \
grey">(37be834)</span></li>
<li>kmymoney/wizards/newloanwizard/summaryeditwizardpagedecl.ui <span style="color: \
grey">(1c7de3e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103622/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic