[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request: Tags: various bugs fix
From: "Alessandro Russo" <axela74 () yahoo ! it>
Date: 2012-11-19 21:14:43
Message-ID: 20121119211443.21799.6864 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 19, 2012, 8:34 a.m., Cristian Oneț wrote:
> > kmymoney/widgets/transaction.cpp, line 336
> > <http://git.reviewboard.kde.org/r/107373/diff/2/?file=95304#file95304line336>
> >
> > If you set the ctx.palette to option palette the selected test is not needed \
> > anymore.
ctx.palette = option.palette; is already present at row 333, if I remove this test \
the text in the selected row is black and not white...
> On Nov. 19, 2012, 8:34 a.m., Cristian Oneț wrote:
> > kmymoney/widgets/transaction.cpp, line 337
> > <http://git.reviewboard.kde.org/r/107373/diff/2/?file=95304#file95304line337>
> >
> > I would go with the following code here:
> >
> > ctx.palette = option.palette;
> >
> > Just to make sure that we use all the stuff that is set in the palette before \
> > calling this function.
Already there, at row 333
- Alessandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107373/#review22206
-----------------------------------------------------------
On Nov. 19, 2012, 12:44 a.m., Alessandro Russo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107373/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 12:44 a.m.)
>
>
> Review request for KMymoney.
>
>
> Description
> -------
>
> Fixed:
> - when closing the split dialog focus go to tag field and not to memo field
> - if the user write in the tag line edit the name of a closed tag or of a tag \
> already included in the transaction an information modal dialog will appear and the \
> line edit will be cleared.
> - restore right color for text in the ledger
>
>
> Diffs
> -----
>
> kmymoney/dialogs/transactioneditor.cpp 1a5e773
> kmymoney/widgets/kmymoneymvccombo.h ad6ae92
> kmymoney/widgets/kmymoneymvccombo.cpp 1053a1a
> kmymoney/widgets/transaction.cpp 7525851
>
> Diff: http://git.reviewboard.kde.org/r/107373/diff/
>
>
> Testing
> -------
>
> Compile and run as intended.
>
>
> Thanks,
>
> Alessandro Russo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107373/">http://git.reviewboard.kde.org/r/107373/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 19th, 2012, 8:34 a.m., <b>Cristian \
Oneț</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107373/diff/2/?file=95304#file95304line336" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/widgets/transaction.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Transaction::paintRegisterCell(QPainter *painter, QStyleOptionViewItemV4 &option, \
const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">335</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">m_selected</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you set the \
ctx.palette to option palette the selected test is not needed anymore.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ctx.palette \
= option.palette; is already present at row 333, if I remove this test the text in \
the selected row is black and not white...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 19th, 2012, 8:34 a.m., <b>Cristian \
Oneț</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107373/diff/2/?file=95304#file95304line337" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kmymoney/widgets/transaction.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Transaction::paintRegisterCell(QPainter *painter, QStyleOptionViewItemV4 &option, \
const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">336</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ctx</span><span class="p">.</span><span class="n">palette</span><span \
class="p">.</span><span class="n">setColor</span><span class="p">(</span><span \
class="n">QPalette</span><span class="o">::</span><span class="n">Text</span><span \
class="p">,</span> <span class="n">option</span><span class="p">.</span><span \
class="n">palette</span><span class="p">.</span><span class="n">color</span><span \
class="p">(</span><span class="n">QPalette</span><span class="o">::</span><span \
class="n">Active</span><span class="p">,</span> <span class="n">QPalette</span><span \
class="o">::</span><span class="n">HighlightedText</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would go with the \
following code here:
ctx.palette = option.palette;
Just to make sure that we use all the stuff that is set in the palette before calling \
this function. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Already \
there, at row 333</pre> <br />
<p>- Alessandro</p>
<br />
<p>On November 19th, 2012, 12:44 a.m., Alessandro Russo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Alessandro Russo.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2012, 12:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed:
- when closing the split dialog focus go to tag field and not to memo field
- if the user write in the tag line edit the name of a closed tag or of a tag \
already included in the transaction an information modal dialog will appear and the \
line edit will be cleared.
- restore right color for text in the ledger</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compile and run as intended.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: \
grey">(1a5e773)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.h <span style="color: \
grey">(ad6ae92)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: \
grey">(1053a1a)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(7525851)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107373/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic