'[Kmymoney-devel] Re: Review Request: Allow the resizing of the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmymoney-devel
Subject:    [Kmymoney-devel] Re: Review Request: Allow the resizing of the
From:       "Cristian Onet" <onet.cristian () gmail ! com>
Date:       2011-01-05 13:45:41
Message-ID: 20110105134541.12545.73660 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6279/
-----------------------------------------------------------

(Updated 2011-01-05 13:45:41.188929)

Review request for kmymoney.

Summary (updated)
-------

With this patch the size of the table is no longer set programmatically but=
 controlled by the size of the dialog + the imported contents. It seems muc=
h better this way. This should be also done for the investments. I removed =
a bit of code that handled setting the column widths if I forgot something =
please let me know.

Diffs
-----

  trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg=
.h 1212010 =

  trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg=
.cpp 1212010 =

  trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.=
h 1212010 =

  trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.=
cpp 1212010 =

Diff: http://svn.reviewboard.kde.org/r/6279/diff

Testing
-------

Thanks,

Cristian

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6279/">http://svn.reviewboard.kde.org/r/6279/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kmymoney.</div>
<div>By Cristian Onet.</div>

<p style="color: grey;"><i>Updated 2011-01-05 13:45:41.188929</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch the size of the table is no longer set programmatically \
but controlled by the size of the dialog + the imported contents. It seems much \
better this way. This should be also done for the investments. I removed a bit of \
code that handled setting the column widths if I forgot something please let me \
know.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h \
<span style="color: grey">(1212010)</span></li>

 <li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp \
<span style="color: grey">(1212010)</span></li>

 <li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h <span \
style="color: grey">(1212010)</span></li>

 <li>trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp \
<span style="color: grey">(1212010)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6279/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

[prev in list] [next in list] [prev in thread] [next in thread] 