[prev in list] [next in list] [prev in thread] [next in thread]
List: kmymoney-devel
Subject: Re: [Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney
From: "Cristian Onet" <onet.cristian () gmail ! com>
Date: 2010-09-08 18:28:18
Message-ID: 20100908182818.31807.42772 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5162/#review7481
-----------------------------------------------------------
Please add the following missing files from the patch:
redefinedlgdecl.ui - missing from the patch
tick.png - present in the patch but since it's a binary it must be sent to =
the mailing list or directly to me (since the patch does not contain the ac=
tual binary file)
nogo.png - the same as the above
- Cristian
On 2010-09-07 17:44:53, Allan Anderson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> =
> (Updated 2010-09-07 17:44:53)
> =
> =
> Review request for kmymoney.
> =
> =
> Summary
> -------
> =
> This is the revised version of the kmymoney csvimporter, which was origin=
ally submitted for me by Cristian. I was unable to find a way to update th=
at, possibly because I was not the original submitter.
> =
> Apart from addressing the original criticisms, I've added further improve=
ments and spent quite a bit of time tightening its error checking.
> =
> As well as the needed files, I've included csvimporterrc. This is not *n=
eeded* by the importer, as it will create one. However, as the user may wi=
sh to supplement the common basic transaction types , in order to cope with=
his own bank file layout idiosyncrasies, it may serve as an illustration o=
r example. Where it should reside, I don't know. I would also wish to inc=
lude some basic instructions, but in what form, and where?
> =
> Apart from functioning as a plugin, it also can produce QIF files if requ=
ired.
> =
> =
> Diffs
> -----
> =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 117262=
8 =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.=
txt PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h =
PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cp=
p PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest=
.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest=
.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
dlg.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
dlg.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
dlgdecl.ui PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
plugin.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
plugin.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporter=
rc PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessi=
ng.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessi=
ng.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentd=
lg.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentd=
lg.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentd=
lgdecl.ui PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investproce=
ssing.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investproce=
ssing.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimpo=
rt.desktop PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimpo=
rt.rc PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/nogo.png UN=
KNOWN =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg=
.h PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg=
.cpp PRE-CREATION =
> /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/tick.png UN=
KNOWN =
> =
> Diff: http://svn.reviewboard.kde.org/r/5162/diff
> =
> =
> Testing
> -------
> =
> I've run Krazy2 and astyle against it, also unit test. =
> =
> Operationally, I've imported CSV files of checking/savings accounts from =
a number of UK and other banks. Also, investment account CSV files from a =
UK and a US investment institution.
> =
> =
> Thanks,
> =
> Allan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5162/">http://svn.reviewboard.kde.org/r/5162/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please add the following \
missing files from the patch: redefinedlgdecl.ui - missing from the patch
tick.png - present in the patch but since it's a binary it must be sent to the \
mailing list or directly to me (since the patch does not contain the actual binary \
file) nogo.png - the same as the above</pre>
<br />
<p>- Cristian</p>
<br />
<p>On September 7th, 2010, 5:44 p.m., Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated 2010-09-07 17:44:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the revised version of the kmymoney csvimporter, which was \
originally submitted for me by Cristian. I was unable to find a way to update that, \
possibly because I was not the original submitter.
Apart from addressing the original criticisms, I've added further improvements \
and spent quite a bit of time tightening its error checking.
As well as the needed files, I've included csvimporterrc. This is not *needed* \
by the importer, as it will create one. However, as the user may wish to supplement \
the common basic transaction types , in order to cope with his own bank file layout \
idiosyncrasies, it may serve as an illustration or example. Where it should reside, \
I don't know. I would also wish to include some basic instructions, but in what \
form, and where?
Apart from functioning as a plugin, it also can produce QIF files if required.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've run Krazy2 and astyle against it, also unit test.
Operationally, I've imported CSV files of checking/savings accounts from a number \
of UK and other banks. Also, investment account CSV files from a UK and a US \
investment institution.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt <span \
style="color: grey">(1172628)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterrc <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.rc \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/nogo.png <span \
style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/tick.png <span \
style="color: grey">(UNKNOWN)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5162/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic