[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [PATCH] crash on clicking add... in the configure-dialog, language tab.
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2001-07-30 18:37:36
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

I get reproducable crashes on hitting "Add..." in Configure->Composer->General
but only on my Laptop.

My other box (a desktop) does work fine.

I traced it down to mComboBox->listBox() being NULL in the constructor of \
NewLanguageDialog, when we don't check it for 0 and call QListBox::sort() through it \
near the end of the constructor.

After applying the patch, the dialog comes up fine and works as expected, BUT the \
icons (country flags) are not shown when the combo box is "idle", ie. the listbox is \
hidden.

They are there on my other box and when I open the combo box.

It might be related to widget styles:

On the laptop and on the desktop, I use the highcolor default (64000-Farben in \
German???) style, though they look completely different to me?!

The desktop shows a listbox with sliders, while the laptops shows one that is \
two-columned and shows all languages w/o scrolling.

I'm in a hurry 'cause I'm going to the cinema with my girl now and would appreciate \
if someone can make sure we know what's going on before we release 2.2.

Marc

Index: configuredialog.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kmail/configuredialog.cpp,v
retrieving revision 1.136
diff -u -3 -p -r1.136 configuredialog.cpp
- --- configuredialog.cpp 2001/07/29 19:13:40     1.136
+++ configuredialog.cpp 2001/07/30 18:33:42
@@ -413,7 +413,13 @@ NewLanguageDialog::NewLanguageDialog( QW
   {
     mComboBox->insertItem( i18n("No more languages available") );
     enableButtonOK( false );
- -  } else mComboBox->listBox()->sort();
+  } else {
+    QListBox *lb = mComboBox->listBox();
+    if (lb)
+      lb->sort();
+    else
+      kdWarning() << "NewLanguageDialog: mComboBox->listBox() == NULL !!!" << endl;
+  }
 }
 
 QString NewLanguageDialog::language( void ) const
- -- 
Marc Mutz <Marc@Mutz.com>
http://marc.mutz.com/
http://www.mathematik.uni-bielefeld.de/~mmutz/
http://EncryptionHOWTO.sourceforge.net/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7ZcUJ3oWD+L2/6DgRAv/EAKCpMceP3QIlXyS4/NqTqSie7C2QbwCfZWWT
lSoQ4KYYZMYGBySsnPaagqE=
=+49h
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]