[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KMail is seriously in need of a code audit
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2001-07-28 10:15:33
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday, 28. July 2001 01:38, Alan Chandler wrote:
> Seriously, to conduct a code audit you need to understand the bigger
> picture - have a view on the design understand what each functions
> purpose is and then review whether the code meets that purpose.

Exactly. This is what I meant when I wrote 'make "flow charts" of the 
code'.

>  My
> biggest critisism of kmail (although I am not singling out kmail in
> particular, much of the source code of open source projects that I
> have looked at is the same) is how little use is made of comments,
> and therefore how hard it is to get that bigger picture of what is
> going on.

Yeah. I also hate this. Therefore I try to always add comments to my 
patches.

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7YpDFGnR+RTDgudgRAicDAJ9jutwmbK3ICNmsP8wPuCYFTfajRwCaAh9x
gLpkoBgvnhqbvlva6/OViNY=
=M+b9
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]