From kmail-devel  Sat Jul 21 12:53:40 2001
From: Michael =?iso-8859-15?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date: Sat, 21 Jul 2001 12:53:40 +0000
To: kmail-devel
Subject: Re: A patch for libkdenetwork
X-MARC-Message: https://marc.info/?l=kmail-devel&m=99572040131862
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------Boundary-00=_GHQTQ968QG7JV5NRJ4WB"


--------------Boundary-00=_GHQTQ968QG7JV5NRJ4WB
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 8bit

On Saturday, 21. July 2001 11:19, you wrote:
> Hi,
>
> I write a patch for kscoringeditor.cpp
> Now edit/add/delete/copy rule were enable/disable when there is rules or
> not. It's not a big patch but I send you this patch because you are kmail
> developer.
>
> Could you say me if it's a good patch, and if I can apply it.

Thanks, the patch looks good to me.

BTW: Please post patches to our mailing list, that all developers can see it.

Regards,
Michael Häckel
--------------Boundary-00=_GHQTQ968QG7JV5NRJ4WB
Content-Type: text/x-diff;
  charset="iso-8859-15";
  name="kscoring_editor.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="kscoring_editor.diff"

Y3ZzIHNlcnZlcjogRGlmZmluZyAuCkluZGV4OiBrc2NvcmluZ2VkaXRvci5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZW5ldHdvcmsvbGlia2RlbmV0d29yay9rc2NvcmluZ2Vk
aXRvci5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjIKZGlmZiAtdSAtdSAtcCAtcjEuMjIg
a3Njb3JpbmdlZGl0b3IuY3BwCi0tLSBrc2NvcmluZ2VkaXRvci5jcHAJMjAwMS8wNy8xOSAwODo0
Njo0MgkxLjIyCisrKyBrc2NvcmluZ2VkaXRvci5jcHAJMjAwMS8wNy8yMSAwOToxNTozMwpAQCAt
NTQ5LDI1ICs1NDksMjcgQEAgUnVsZUxpc3RXaWRnZXQ6OlJ1bGVMaXN0V2lkZ2V0KEtTY29yaW5n
TQogICB0b3BMLT5hZGRXaWRnZXQocnVsZUxpc3QpOwogICB1cGRhdGVSdWxlTGlzdCgpOwogICBR
SEJveExheW91dCAqYnRuTCA9IG5ldyBRSEJveExheW91dCh0b3BMLEtEaWFsb2c6OnNwYWNpbmdI
aW50KCkpOworCisgIGVkaXRSdWxlPTBMOwogICAvLyBpZiB3ZSdyZSBzdGFuZGFsb25lLCB3ZSBu
ZWVkIGFuIGFkZGl0aW9uYWwgZWRpdCBidXR0b24KICAgaWYgKHN0YW5kYWxvbmUpIHsKLSAgICBR
UHVzaEJ1dHRvbiAqZWRpdFJ1bGUgPSBuZXcgUVB1c2hCdXR0b24odGhpcyk7CisgICAgZWRpdFJ1
bGUgPSBuZXcgUVB1c2hCdXR0b24odGhpcyk7CiAgICAgZWRpdFJ1bGUtPnNldFBpeG1hcCggQmFy
SWNvbigiZWRpdCIsIEtJY29uOjpTaXplU21hbGwpICk7CiAgICAgUVRvb2xUaXA6OmFkZChlZGl0
UnVsZSxpMThuKCJFZGl0IHJ1bGUiKSk7CiAgICAgYnRuTC0+YWRkV2lkZ2V0KGVkaXRSdWxlKTsK
ICAgICBjb25uZWN0KGVkaXRSdWxlLFNJR05BTChjbGlja2VkKCkpLHRoaXMsU0xPVChzbG90RWRp
dFJ1bGUoKSkpOwogICB9Ci0gIFFQdXNoQnV0dG9uICpuZXdSdWxlID0gbmV3IFFQdXNoQnV0dG9u
KHRoaXMpOworICBuZXdSdWxlID0gbmV3IFFQdXNoQnV0dG9uKHRoaXMpOwogICBuZXdSdWxlLT5z
ZXRQaXhtYXAoIEJhckljb24oICJmaWxlbmV3IiwgS0ljb246OlNpemVTbWFsbCApICk7CiAgIFFU
b29sVGlwOjphZGQobmV3UnVsZSxpMThuKCJOZXcgcnVsZSIpKSwKICAgYnRuTC0+YWRkV2lkZ2V0
KG5ld1J1bGUpOwogICBjb25uZWN0KG5ld1J1bGUsIFNJR05BTChjbGlja2VkKCkpLCB0aGlzLCBT
TE9UKHNsb3ROZXdSdWxlKCkpKTsKLSAgUVB1c2hCdXR0b24gKmRlbFJ1bGUgPSBuZXcgUVB1c2hC
dXR0b24odGhpcyk7CisgIGRlbFJ1bGUgPSBuZXcgUVB1c2hCdXR0b24odGhpcyk7CiAgIGRlbFJ1
bGUtPnNldFBpeG1hcCggQmFySWNvbiggImVkaXRkZWxldGUiLCBLSWNvbjo6U2l6ZVNtYWxsICkg
KTsKICAgUVRvb2xUaXA6OmFkZChkZWxSdWxlLGkxOG4oIlJlbW92ZSBydWxlIikpOwogICBidG5M
LT5hZGRXaWRnZXQoZGVsUnVsZSk7CiAgIGNvbm5lY3QoZGVsUnVsZSwgU0lHTkFMKGNsaWNrZWQo
KSksIHRoaXMsIFNMT1Qoc2xvdERlbFJ1bGUoKSkpOwotICBRUHVzaEJ1dHRvbiAqY29weVJ1bGUg
PSBuZXcgUVB1c2hCdXR0b24odGhpcyk7CisgIGNvcHlSdWxlID0gbmV3IFFQdXNoQnV0dG9uKHRo
aXMpOwogICBjb3B5UnVsZS0+c2V0UGl4bWFwKEJhckljb24oImVkaXRjb3B5IiwgS0ljb246OlNp
emVTbWFsbCkpOwogICBRVG9vbFRpcDo6YWRkKGNvcHlSdWxlLGkxOG4oIkNvcHkgcnVsZSIpKTsK
ICAgYnRuTC0+YWRkV2lkZ2V0KGNvcHlSdWxlKTsKQEAgLTU5MSwxMiArNTkzLDIyIEBAIFJ1bGVM
aXN0V2lkZ2V0OjpSdWxlTGlzdFdpZGdldChLU2NvcmluZ00KICAgICAgICAgICB0aGlzLFNMT1Qo
dXBkYXRlUnVsZUxpc3QoKSkpOwogICBjb25uZWN0KG1hbmFnZXIsU0lHTkFMKGNoYW5nZWRSdWxl
TmFtZShjb25zdCBRU3RyaW5nJixjb25zdCBRU3RyaW5nJikpLAogICAgICAgICAgIHRoaXMsU0xP
VChzbG90UnVsZU5hbWVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmLGNvbnN0IFFTdHJpbmcmKSkpOwor
ICB1cGRhdGVCdXR0b24oKTsKIH0KIAogUnVsZUxpc3RXaWRnZXQ6On5SdWxlTGlzdFdpZGdldCgp
CiB7CiB9CiAKK3ZvaWQgUnVsZUxpc3RXaWRnZXQ6OnVwZGF0ZUJ1dHRvbigpCit7CisgICAgYm9v
bCBzdGF0ZT1ydWxlTGlzdC0+Y291bnQoKT4wOworICAgIGlmKGVkaXRSdWxlKQorICAgICAgICBl
ZGl0UnVsZS0+c2V0RW5hYmxlZChzdGF0ZSk7CisgICAgZGVsUnVsZS0+c2V0RW5hYmxlZChzdGF0
ZSk7CisgICAgY29weVJ1bGUtPnNldEVuYWJsZWQoc3RhdGUpOworfQorCiB2b2lkIFJ1bGVMaXN0
V2lkZ2V0Ojp1cGRhdGVSdWxlTGlzdCgpCiB7CiAgIGtkRGVidWcoNTEwMCkgPDwgIlJ1bGVMaXN0
V2lkZ2V0Ojp1cGRhdGVSdWxlTGlzdCgpIiA8PCBlbmRsOwpAQCAtNjc5LDExICs2OTEsMTMgQEAg
dm9pZCBSdWxlTGlzdFdpZGdldDo6c2xvdFJ1bGVTZWxlY3RlZChpbgogICBpZiAoaWR4ID49IHJ1
bGVMaXN0LT5jb3VudCgpKSByZXR1cm47CiAgIFFTdHJpbmcgcnVsZU5hbWUgPSBydWxlTGlzdC0+
dGV4dChpbmRleCk7CiAgIHNsb3RSdWxlU2VsZWN0ZWQocnVsZU5hbWUpOworICB1cGRhdGVCdXR0
b24oKTsKIH0KIAogdm9pZCBSdWxlTGlzdFdpZGdldDo6c2xvdE5ld1J1bGUoKQogewogICB1cGRh
dGVSdWxlTGlzdChtYW5hZ2VyLT5hZGRSdWxlKCkpOworICB1cGRhdGVCdXR0b24oKTsKIH0KIAog
dm9pZCBSdWxlTGlzdFdpZGdldDo6c2xvdERlbFJ1bGUoKQpAQCAtNjkzLDYgKzcwNyw3IEBAIHZv
aWQgUnVsZUxpc3RXaWRnZXQ6OnNsb3REZWxSdWxlKCkKICAgICBtYW5hZ2VyLT5kZWxldGVSdWxl
KHJ1bGUpOwogICAvLyBnb3RvIHRoZSBuZXh0IHJ1bGUKICAgc2xvdEVkaXRSdWxlKCk7CisgIHVw
ZGF0ZUJ1dHRvbigpOwogfQogCiB2b2lkIFJ1bGVMaXN0V2lkZ2V0OjpzbG90Q29weVJ1bGUoKQpA
QCAtNzAxLDYgKzcxNiw3IEBAIHZvaWQgUnVsZUxpc3RXaWRnZXQ6OnNsb3RDb3B5UnVsZSgpCiAg
IGlmIChydWxlKSB7CiAgICAgbWFuYWdlci0+Y29weVJ1bGUocnVsZSk7CiAgIH0KKyAgdXBkYXRl
QnV0dG9uKCk7CiB9CiAKIC8vPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpJbmRleDoga3Njb3JpbmdlZGl0
b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUva2RlbmV0d29yay9saWJrZGVuZXR3
b3JrL2tzY29yaW5nZWRpdG9yLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTUKZGlmZiAtdSAt
dSAtcCAtcjEuMTUga3Njb3JpbmdlZGl0b3IuaAotLS0ga3Njb3JpbmdlZGl0b3IuaAkyMDAxLzA3
LzE5IDA4OjQ2OjQyCTEuMTUKKysrIGtzY29yaW5nZWRpdG9yLmgJMjAwMS8wNy8yMSAwOToxNToz
MwpAQCAtMTkwLDYgKzE5MCw5IEBAIHB1YmxpYzoKICAgUnVsZUxpc3RXaWRnZXQoS1Njb3JpbmdN
YW5hZ2VyICptLCBib29sID1mYWxzZSwgUVdpZGdldCAqcCA9MCwgY29uc3QgY2hhciAqbiA9MCk7
CiAgIH5SdWxlTGlzdFdpZGdldCgpOwogICBRU3RyaW5nIGN1cnJlbnRSdWxlKCkgY29uc3QgeyBy
ZXR1cm4gcnVsZUxpc3QtPmN1cnJlbnRUZXh0KCk7IH0KK3Byb3RlY3RlZDoKKyAgdm9pZCB1cGRh
dGVCdXR0b24oKTsKKwogc2lnbmFsczoKICAgdm9pZCBydWxlU2VsZWN0ZWQoY29uc3QgUVN0cmlu
ZyYpOwogICB2b2lkIHJ1bGVFZGl0ZWQoY29uc3QgUVN0cmluZyYpOwpAQCAtMjEyLDcgKzIxNSwx
MCBAQCBwcml2YXRlOgogICBLTGlzdEJveCAqcnVsZUxpc3Q7CiAgIC8qKiB0aGUgY3VycmVudCBn
cm91cCAqLwogICBRU3RyaW5nIGdyb3VwOwotCisgIFFQdXNoQnV0dG9uICplZGl0UnVsZTsKKyAg
UVB1c2hCdXR0b24gKm5ld1J1bGU7CisgIFFQdXNoQnV0dG9uICpkZWxSdWxlOworICBRUHVzaEJ1
dHRvbiAqY29weVJ1bGU7CiAgIEtTY29yaW5nTWFuYWdlciAqbWFuYWdlcjsKIH07CiAK

--------------Boundary-00=_GHQTQ968QG7JV5NRJ4WB--

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail