[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: PATCH: sanity checking
From:       Stefan Taferner <taferner () kde ! org>
Date:       2001-07-19 7:09:34
[Download RAW message or body]

On Tuesday, 17. July 2001 12:51, Don Sanders wrote:
> On Tuesday 17 July 2001 10:11, Stefan Taferner wrote:
[...]
> > Hmm... isn't KMail locking the folders?
>
> KMail does not lock files in ~/Mail, when we tried to do
> that many NFS users complained that KMail hung on startup.
> There has been an ongoing discussion about this associated
> with Bug#28903.

Hmpf. Ok.

> I would be happy to lock files in ~/Mail if it didn't cause
> problems for NFS users. (But I'm strongly against this
> system of arbitrary programs updating files in the ~/Mail
> folder. That's not a scalable solution.)

Maybe I do not get the point, but last time I looked at the
code (some weeks ago) there was code for various locking
forms.

I am tempted to say "make it configurable", but this might
not solve the problem well.

How about some detection code that tests if locking is
possible? I am thinking about putting an alarm signal on
guard to stop the locking attempt after, say, 2 seconds?
If locking fails kmail could use something else.

> > Besides that the idea sounds good. The only thing is that
> > I would not call it "critical error", rather "attention"
> > or "warning". Not?
>
> I have called it critical error, as I cause KMail to
> terminate via an exit(1) after the condition has occurred.
> Perhaps KMail could continue safely with some extra work,
> but that is not my immediate concern. Instead preventing
> mail loss is.

Ok, then it should be "critical", yes :-)

> If one of these critical errors occurs then I output debug
> info to the terminal but unfortunately I don't show any
> graphical dialog. I'll try to fix that once the message
> freeze is over, (however the KMail process must be
> terminated and the dialog shown by another process)

Doesn't a modal dialog block the program? Then kmail
could terminate afterwards.

Kind regards,
Stefan
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]