From kmail-devel  Sat Jun 30 21:44:03 2001
From: Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date: Sat, 30 Jun 2001 21:44:03 +0000
To: kmail-devel
Subject: PATCH: Internal POP3 error
X-MARC-Message: https://marc.info/?l=kmail-devel&m=99394383402252
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------Boundary-00=_F1JRVXJCFUMR5II8LR9Z"


--------------Boundary-00=_F1JRVXJCFUMR5II8LR9Z
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

Hi,

attached patch fixes the problem, that the pop3 kio slave currently reports 
on average after every 2000 mails and internal error.

Actually I though, I tested all cases by setting the packet size temporarily 
to 1, but I always tested only retrieving a single mail and not several.

If you change 
  ssize_t readlen = Read(buf, sizeof(buf)-1);
to
  ssize_t readlen = Read(buf, 1);
it is always reproducable, if there are more than one mails on the server.

Please review.

Regards,
Michael Häckel
--------------Boundary-00=_F1JRVXJCFUMR5II8LR9Z
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="internal-error.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="internal-error.diff"

SW5kZXg6IHBvcDMuY2MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZWJhc2Uva2lv
c2xhdmUvcG9wMy9wb3AzLmNjLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExNQpkaWZmIC11IC0z
IC1wIC1yMS4xMTUgcG9wMy5jYwotLS0gcG9wMy5jYwkyMDAxLzA2LzI0IDEwOjMzOjI5CTEuMTE1
CisrKyBwb3AzLmNjCTIwMDEvMDYvMzAgMjE6MzY6NDIKQEAgLTc2NCw3ICs3NjQsMTEgQEAgdm9p
ZCBQT1AzUHJvdG9jb2w6OmdldCAoY29uc3QgS1VSTCYgdXJsKQogCQkJCS8vICIuIiBtZWFucyBl
bmQgb2YgZGF0YQogCQkJCWZvciAoc3NpemVfdCBpID0gMDsgaSA8IHJlYWRsZW47IGkrKykKIAkJ
CQl7Ci0JCQkJICBpZiAoKmJ1ZjEgPT0gJ1xyJyAmJiBlYXQpIHsgZW5kT2ZNYWlsID0gdHJ1ZTsg
YnJlYWs7IH0KKwkJCQkgIGlmICgqYnVmMSA9PSAnXHInICYmIGVhdCkgeworCQkJCSAgICBlbmRP
Zk1haWwgPSB0cnVlOworCQkJCSAgICBpZiAoaSA9PSByZWFkbGVuIC0gMSAmJiAhQXRFT0YoKSkg
UmVhZChidWYsIDEpOworCQkJCSAgICBicmVhazsKKwkJCQkgIH0KIAkJCQkgIGVsc2UgaWYgKCpi
dWYxID09ICdcbicpIHsgbmV3bGluZSA9IHRydWU7IGVhdCA9IGZhbHNlOyB9CiAJCQkJICBlbHNl
IGlmICgqYnVmMSA9PSAnLicgJiYgbmV3bGluZSkgeyBuZXdsaW5lID0gZmFsc2U7IGVhdCA9IHRy
dWU7IH0KIAkJCQkgIGVsc2UgeyBuZXdsaW5lID0gZmFsc2U7IGVhdCA9IGZhbHNlOyB9Cg==

--------------Boundary-00=_F1JRVXJCFUMR5II8LR9Z--
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail