[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Kpgp sane passphrase handling
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2001-06-30 16:32:07
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday, 30. June 2001 20:05, Marc Mutz wrote:
> On Saturday 30 June 2001 16:38, Ingo Klöcker wrote:
[snip]
> We should merge the different password dialogs that float around in
> kdelibs for KDE2.3: KIO uses it's own, KPasswordDialog is another
> one, no-one seems to use and perhaps another dozen apps do it
> themselves, too.
>
> We could then add setKeep() to this dialog.

This would be reasonable.

> OK, I'll make a patch that contains the non-passphrase-related
> changes and another one that
>
> a. does new-style passphrase handling (char*)
> b. modifies the old passphrase dialog to use a KPasswordEdit instead
> of plain QLineEdit.

This sounds good.


> > Why do you setStorePassPhrase( false ) if the user hits Cancel in
> > the password dialog? IMHO this line should be removed.
>
> If the user hits cancel, we can't use data entered into the dialog.
> So we must use defaults.

Exactly. And the default value should be the value the user chose in 
the configuration dialog (option "keep passphrase in memory").

> Not storing the passphrase is IMO a very
> decent default. The user can always switch back to storing on the
> next passphrase dialog (which comes up this way or another, since we
> wiped the passphrase).

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7Pf8HGnR+RTDgudgRAtuPAKCTGLiZUmq2DRfCxS/qeXQ5JTj+FgCeI5jK
y26PzFBW7k79e+A8uhiCOSI=
=KivV
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]