[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Bug#27177: Lost all mail in inbox
From:       Don Sanders <sanders () kde ! org>
Date:       2001-06-14 12:28:47
[Download RAW message or body]

On Thursday 14 June 2001 08:43, Michael Häckel wrote:

> Hi,
>
> I just want to note, that these replies don't go to the
> submitter by default.

Oops. Thanks, I forward some of my earlier mails directly 
to people.

One thing relatd to this bug. When proofreading the new 
kmfolder code in Sam's patch I noticed that, the writeindex code
used to look like this: 

  for (i=0; i<mMsgList.high(); i++)
  {
    if (!(msgBase = mMsgList[i])) continue;
/*** No error checking in the following line ***/
    fprintf(mIndexStream, "%s\n", (const char*)msgBase->asIndexString());
  }
  if (fflush(mIndexStream) != 0) return errno;
  if (fclose(mIndexStream) != 0) return errno;

  _rename(tempName, indexLocation());
  mIndexStream = fopen(indexLocation(), "r+"); // index file

  mDirty = FALSE;
  return 0;

(I added the comment). I think there is a lack of error checking 
here, (the fflush and fclose will succeed even if disk space is 
exhausted) and that this could cause problems 
(truncated index file) if disk space is exhausted while writing 
the index.

The new code checks for this now

> I don't know, if that is a problem
> with the mailing list overriding them, or with the bug
> system no longer adding Reply-To headers.

Hopefully Coolo, reads these messages, I guess he's the 
one that cares for that.

Don.
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]