[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Fixes problem with encryptToSelf
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2001-06-14 9:40:02
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday, 13. June 2001 08:21, Andreas Gungl wrote:

> Am Mittwoch 13 Juni 2001 00:46 schrieb Ingo Klöcker:
> > Hi,
> >
> > since the PGP user id depends on the identity encryptToSelf didn't
> > work anymore because the message was encrypted to the no longer
> > existant global PGP user id instead of being encrypted to the
> > identity dependant PGP user id.
> > The attached patch fixes this problem. To solve this problem I had
> > to add a parameter (the PGP user id which should be used) to
> > Kpgp::encryptFor(...) and Kpgp::sign(...). Therefore all programs
> > which depend on libkdenetwork and call Kpgp::encryptFor(...) and
> > Kpgp::sign(...) will have to be adapted. My patch also includes the
> > necessary patch for KMail. I guess KNode will have to be patched in
> > a similar way if it also uses identities. But as I don't know KNode
> > I will leave this to the maintainers of KNode (hi, Mathias).
>
> IMO it's too much effort adding parameters to those two Kpgp methods.
> Wouldn't it be enough to call Kpgp::setUser(<Id>) before doing a call
> to Kpgp::encryptFor(...) and Kpgp::sign(...)?

Adding a new parameter makes it clear that Kpgp::encryptFor(...) and 
Kpgp::sign(...) will only work correctly if the PGP identity is given 
(although this is an optional parameter in my patch which was not a 
good idea because the correct behaviour of these two member functions 
depends on the given PGP identity). IHMO it makes no sense to force 
developers which use Kpgp to always first call setUser(<Id>) before 
calling encryptFor(...) or sign(...). At least one developer will 
forget to make this mandatory call of setUser(<Id>) and then he will 
wonder why his program behaves strange.

> > BTW, I also commented out the saving to and loading from kpgprc of
> > pgpUser as there is no longer a global PGP user id.
>
> When it's no longer needed by Knode then we could delete these lines.
> We won't need them as comments because we have CVS. ;-)

As you wish. ;-)

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7KIZyGnR+RTDgudgRAhttAJoD0zobmA1jlebtRcjfDHPAAO4FCACaA1D3
xO3ccpvFXIETLuUznwLfstQ=
=haoW
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]