[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: DCOP interface incompatible to older KMail versions
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-06-11 9:15:16
[Download RAW message or body]

On Sunday, 10. June 2001 23:33, Cornelius Schumacher wrote:
>
> I don't think that default arguments work over DCOP. That means that we
> need an extra function.
>
> My test case is KOrganizer, which currently uses the old DCOP interface
> to mail appointments via KMail.

I tried to add also the old version, but I didn't manage to get KOrganizer to 
send mails.
Does the attached patch work for you, or could you provide a patch, that 
really works?
On the other hand KOrganizer is in CVS and will probably be released with KDE 
2.2. Is it really so hard to change it to use the new function? I doubt, that 
many people will use KOrganizer from KDE 2.1 and KMail from KDE 2.2.

Regards,
Michael Häckel
["dcop.diff" (text/plain)]

Index: kmailIface.h
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmailIface.h,v
retrieving revision 1.8
diff -u -3 -p -r1.8 kmailIface.h
--- kmailIface.h	2001/05/08 08:03:02	1.8
+++ kmailIface.h	2001/06/11 09:08:57
@@ -24,6 +24,10 @@ k_dcop:
   virtual int openComposer(const QString &to, const QString &cc,
                            const QString &bcc, const QString &subject,
                            const QString &body, int hidden,
+                           const KURL &messageFile) = 0;
+  virtual int openComposer(const QString &to, const QString &cc,
+                           const QString &bcc, const QString &subject,
+                           const QString &body, int hidden,
                            const KURL &messageFile,
 			   const KURL &attachURL) = 0;
   virtual int send(int composerId, int how) = 0; //0=default,1=now,2=later
Index: kmkernel.h
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmkernel.h,v
retrieving revision 1.17
diff -u -3 -p -r1.17 kmkernel.h
--- kmkernel.h	2001/06/01 20:34:04	1.17
+++ kmkernel.h	2001/06/11 09:08:57
@@ -40,6 +40,14 @@ public:
   int openComposer (const QString &to, const QString &cc, const QString &bcc,
                     const QString &subject, const QString &body, int hidden,
                     const KURL &messageFile, const KURL &attachURL);
+  // For backward compatibility
+  int openComposer (const QString &to, const QString &cc, const QString &bcc,
+                    const QString &subject, const QString &body, int hidden,
+                    const KURL &messageFile)
+  {
+    return openComposer(to, cc, bcc, subject, body, hidden, messageFile,
+    KURL());
+  }
   void openReader();
   int ready();
   int send(int composerId, int how); //0=now, 1=later

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]