[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] The Saga Continues: Next round of QT_NO_... fixes.
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2001-06-10 18:26:46
[Download RAW message or body]

On Sonntag, 10. Juni 2001 03:57 Marc Mutz wrote:

Hiya,

> I've gone through some more files and made them compile with
> QT_NO_ASCII_CAST and QT_NO_COMPAT.

great job! I'm just looking at the diffs:

> - kmail-kmmainwin-cleanup.diff:
>
> I've fixed the char* cast that was needed to feed mNewMailCmd to
> system() by using KShellProcess. I'm not quite sure which runmode to
> choose. KProcess::Block (currently used) or KProcess::DontCare. The
> latter seems to be more logical in this case, but I'm not sure if you
> can use it if you created your KProcess on the stack.

That shouldn't make a problem, as long as you don't use NotifyOnExit.

> - kmail-readerwin-cleanup.diff

For all filesystem related operations where you can't use QString, you should 
use QFile::encodeName( qstring ). Currently it doesn't make a difference, 
because that one does QString::local8Bit(), but if that changes, we don't 
have to port again.

> This change may affect other apps using this lib.
> libkdenetwork doesn't need to be BC, right?

Not yet, I guess. After it's released, it would be nice to keep it BC.

Cheers,
Carsten Pfeiffer
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]