[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KPGP patch: pgp auto detection
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2001-06-02 20:24:59
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 02 June 2001 20:47, Christian Gebauer wrote:
> Hi,
>
> KPGP currently uses auto detection of the pgp version as default setting,
> which is probably a good idea. Unfortunally the auto detection code will
> start the external pgp binary on every start of KMail/KNode, if you have
> pgp 2.x or 6.x installed.

This is to find out if the pgp executable is PGP 2.x or PGP 6.x which is 
important to know because they work a little bit different and need extra 
subclasses of KpgpBase.

> Therefore I would like to apply the attached patch to KPGP.
> With this patch the KPgpBase instance will be created when it
> is first needed, not on startup. Unfortunally I had to make
> a bunch of methods in KPGP non-const, but IHMO starting external
> application during startup is way to costly, so I see no
> alternative.
>
> Opinions?

Lot of changes plus some cleanup in the formatting. Nice work. I hope it's 
worth it. I'm not sure how many people are using PGP resp GnuPG. At least 
program startup should speed up a little bit. This is anyway a problem for 
KDE - so it's okay to optimize this.

Two ideas around your patch:

IMO it should be possible to disable PGP functionality. Let's think about 
having PGP/GnuPG installed on the machine but no keyring for me. I would 
not like starting those applications then. Shouldn't we add another option 
"off" in the settings page and use KpgpBase class as dummy?

When I'm a new user KMail will use the auto mode to detect the correct PGP 
application. Should we give some feedback to the user forcing him not to 
use auto any longer but adjust the settings according the detected program?

Well, if nobody objects against this change, then it's okay to apply these 
changes. Otherwise we should discuss it again.

Regards,
Andreas
- -- 
    ~
  ' v '
 //   \\
/(     )\  Powered by Penguin.
  ^ ' ^


-----BEGIN PGP SIGNATURE-----
Version: PGP 6.5.1

iQA/AwUBOxlLnFYY4hXeG3lPEQK16wCg3fCutHNXmTuf71rfphTf/ytPJvwAoLWz
HYRNNBiaRCZqn6jKnqxjzpZF
=R6zK
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]