From kmail-devel Sun Apr 29 20:39:57 2001 From: Don Sanders Date: Sun, 29 Apr 2001 20:39:57 +0000 To: kmail-devel Subject: Re: Memory leaks in KMail X-MARC-Message: https://marc.info/?l=kmail-devel&m=98857745706524 On Sunday 29 April 2001 21:17, Stephan Kulow wrote: > On Friday, 27. April 2001 22:46, Don Sanders wrote: > > On Friday 27 April 2001 16:47, Denis Perchine wrote: > > > Hello, > > > > > > Read a CVS message, that memory leak was fixed in KHTML. > > > And thought that this will finally fix the problem with memory leak > > > when reading mails. But it is not the case. When I go to the next > > > message approximately 100 kbytes is leaked. At least KMail grows in > > > size. Even when I came back to the same message it grows. > > > > > > Also it grows by approx. 200K when I right click on the item, and get > > > popup menu. Possibly this is a problem of kdelibs... But this is really > > > unacceptable. After a day of work KMail use 100-150Mb of memory. > > > > > > Any ideas? > > > > It's updateMessageMenu again. Just "return;" in > > KMMainWin::updateMessageMenu() to verify that yourself. > > > > Maybe there was always a memory leak there, maybe it is much more of a > > problem now as maybe updateMessageMenu is called much more often than it > > used to be. Maybe it was only called on right click or when clicking on > > the message menu but now it is (more or less) called whenever a message > > is read. > > > > IMO obviously updateMessageMenu should only be called on right click of a > > message header or when the message menu is pulled down. Coolo any chance > > of you agreeing on this? > > As I told you, this can't work as the toolbar buttons are disabled too. The > name is just wrong, haem historical. I believe enabling/disabling of (not yet created?) toolbar buttons is less important than fixing the memory leak. BFN, Don. _______________________________________________ Kmail Developers mailing list Kmail@master.kde.org http://master.kde.org/mailman/listinfo/kmail