From kmail-devel Sat Apr 28 22:52:24 2001 From: Ingo =?iso-8859-1?q?Kl=F6cker?= Date: Sat, 28 Apr 2001 22:52:24 +0000 To: kmail-devel Subject: PATCH: filter configuration (destination folder ComboBox) X-MARC-Message: https://marc.info/?l=kmail-devel&m=98849978407858 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------Boundary-00=_C7YI9KVVWVCAFQFMKHLO" --------------Boundary-00=_C7YI9KVVWVCAFQFMKHLO Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, actually this is no real bug. But it's something Marc should change while he is working on the filters. Buggy behaviour which should be changed: If you delete a folder which was the destination folder of a filter, and then open the configuration for this filter, the destination folder will be set to the first non-system-folder. Or at least it seems to be set to this folder although the destination folder is undefined (NULL). This is really irritating. IMHO the first entry in the destination folder combo box should be something like "" (similar to the in the action ComboBox). The attached patch adds the "" entry to the destination folder ComboBox. I don't know if it's better to apply this small patch directly to cvs or if it's better to let Marc add this patch to his work on the filters. Regards, Ingo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE660msGnR+RTDgudgRAgQbAJ96hEfs9HPhvrc7W45lDApzdQqM2ACg2oHK UKHVTZGcnKzDrLrUotnDH3g= =82Rc -----END PGP SIGNATURE----- --------------Boundary-00=_C7YI9KVVWVCAFQFMKHLO Content-Type: text/x-c++; charset="iso-8859-1"; name="filtertransferactioncombobox.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="filtertransferactioncombobox.diff" SW5kZXg6IGttZmlsdGVyYWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUv a2RlbmV0d29yay9rbWFpbC9rbWZpbHRlcmFjdGlvbi5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNDEKZGlmZiAtdSAtMyAtcCAtcjEuNDEga21maWx0ZXJhY3Rpb24uY3BwCi0tLSBrbWZpbHRl cmFjdGlvbi5jcHAJMjAwMS8wNC8xNyAyMDo0NTo0NAkxLjQxCisrKyBrbWZpbHRlcmFjdGlvbi5j cHAJMjAwMS8wNC8yOCAyMjowMDowMApAQCAtMTUwLDggKzE1MCw4IEBAIFFXaWRnZXQqIEtNRmls dGVyQWN0aW9uTW92ZTo6Y3JlYXRlUGFyYW0KIHZvaWQgS01GaWx0ZXJBY3Rpb25Nb3ZlOjphcHBs eVBhcmFtV2lkZ2V0VmFsdWUoUVdpZGdldCogYVBhcmFtV2lkZ2V0KQogewogICBRQ29tYm9Cb3gq IGNieCA9IChRQ29tYm9Cb3gqKWFQYXJhbVdpZGdldDsKLSAgaWYgKChjYngtPmN1cnJlbnRJdGVt KCkgPj0gMCkgJiYgKGNieC0+Y3VycmVudEl0ZW0oKSA8IChpbnQpZ2ZvbGRlcnMuY291bnQoKSkp Ci0gICAgbURlc3QgPSAoKmdmb2xkZXJzLmF0KGNieC0+Y3VycmVudEl0ZW0oKSkpOworICBpZiAo KGNieC0+Y3VycmVudEl0ZW0oKSA+IDApICYmIChjYngtPmN1cnJlbnRJdGVtKCkgPD0gKGludCln Zm9sZGVycy5jb3VudCgpKSkKKyAgICBtRGVzdCA9ICgqZ2ZvbGRlcnMuYXQoY2J4LT5jdXJyZW50 SXRlbSgpIC0gMSkpOyAvLyAtMSBiZWNhdXNlIG9mIHRoZSBhZGRpdGlvbmFsICI8dW5kZWZpbmVk PiIgZW50cnkgaW4gdGhlIENvbWJvQm94CiAgIGVsc2UKICAgICBtRGVzdCA9IDA7CiB9CkluZGV4 OiBrbWZpbHRlcmRsZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZW5ldHdv cmsva21haWwva21maWx0ZXJkbGcuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjUzCmRpZmYg LXUgLTMgLXAgLXIxLjUzIGttZmlsdGVyZGxnLmNwcAotLS0ga21maWx0ZXJkbGcuY3BwCTIwMDEv MDQvMTcgMjA6NDU6NDQJMS41MworKysga21maWx0ZXJkbGcuY3BwCTIwMDEvMDQvMjggMjI6MDA6 MDAKQEAgLTQzMCwxNSArNDMwLDE0IEBAIFFDb21ib0JveCogS01GaWx0ZXJEbGc6OmNyZWF0ZUZv bGRlckNvbWIKIAogICBjYngtPnNldEZpeGVkSGVpZ2h0KG1DYnhIZWlnaHQpOwogCi0gIFFTdHJp bmdMaXN0OjpJdGVyYXRvciBzdDsKLSAgZm9yKCBzdCA9IHN0ci0+YmVnaW4oKTsgc3QgIT0gc3Ry LT5lbmQoKTsgKytzdCkKLSAgICBjYngtPmluc2VydEl0ZW0oKnN0KTsKKyAgY2J4LT5pbnNlcnRJ dGVtKGkxOG4oIjx1bmRlZmluZWQ+IikpOworICBjYngtPmluc2VydFN0cmluZ0xpc3QoKnN0cik7 CiAKICAgUUd1YXJkZWRQdHI8S01Gb2xkZXI+IGZvbGRlcjsKICAgd2hpbGUgKGZvbGRlcnMtPmF0 KGkpICE9IGZvbGRlcnMtPmVuZCgpKSB7CiAgICAgZm9sZGVyID0gKmZvbGRlcnMtPmF0KGkpOwog ICAgIGlmIChmb2xkZXIgPT0gY3VyRm9sZGVyKQotICAgICAgaWR4ID0gaTsKKyAgICAgIGlkeCA9 IGkrMTsgLy8gKzEgYmVjYXVzZSBvZiB0aGUgYWRkaXRpb25hbCAiPHVuZGVmaW5lZD4iIGVudHJ5 CiAgICAgKytpOwogICB9CiAgIGlmIChpZHg+PTApIGNieC0+c2V0Q3VycmVudEl0ZW0oaWR4KTsK --------------Boundary-00=_C7YI9KVVWVCAFQFMKHLO-- _______________________________________________ Kmail Developers mailing list Kmail@master.kde.org http://master.kde.org/mailman/listinfo/kmail