[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: grmph... (was: [PATCH] filter changes).
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-04-28 19:20:11
[Download RAW message or body]

On Thursday 26 April 2001 22:20, Marc Mutz wrote:
>
> Marc Mutz wrote:
> > Hi!
> >
> > The attached patch is against yesterday's or so CVS-HEAD. I've developed
> > this patch in the 2.1.1 branch, and then proted it to current CVS. I
> > made sure that it compiles. There was the "g++ ... -o foo.moc" error
> > again, which went away (at least for me), when doing "make distclean;
> > make -f Makefile.cvs; ./configure" again.
> >
> > Please test and comment. There is still some stuff left to do, but I
> > want people to help test (and yes, I've tested it quite a bit :-).

In general, the dialog looks very nice now.

After a make cvs-clean and directely including kmfilter.h and 
kmfilteraction.h in kmfilterdlg.h it compiled.
This QList<...> don't seem to work for me otherwise. Don't know, what you are 
doing different.

- A little layout bug: If one of the filter rules is about a field with a
  self defined long name the layout is not is a bit strange, see attachment.
  I think, you should use a single QGridLayout for all filter rules.
- When resizing the dialog, only the width of the right edit fields grow. It
  is also possible to define a strech value for several coulumns in a layout.
  Then they grow all in a defined ratio.
- The renaming of rules is now handled very well, however what is the purpose
  of the Clear button in the rename dialog? If I click Clear and then Ok it
  has the same effect like when clicking Cancel. If it would revert to the
  automatic generated name, it would at least be useful. Since the text is
  highlight it is anyway deleted by default, when typing.
- Is there a reason, why there are always at least two filter criteria
  displayed and not only one by default like for the actions?

The execute rule still seems to work.

I think when the bugs you mentiond and above things, as far as they are bugs 
are fixed, then the patch is ready for CVS and you can work on additional 
features in a new patch.

Regards,
Michael Häckel
["filter.png" (image/png)]
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]